added email presence validation to openid

closes #1658

added test for openid

fixed robocup offences

written tests for email presence validation

minor changes

shifted omniauth callback tests to rspec controllers

fixed linting bug

minor changes

minor changes

spec/controllers/users/omniauth_callbacks_controller_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe Users::OmniauthCallbacksController do
+  context 'email is not there in auth hash' do
+    before do
+      stub_env_for_omniauth
+      get :google
+    end
+
+    it { expect(flash[:error]).to eq('Email field is missing in your google account') }
+  end
+end
+
+def stub_env_for_omniauth
+  request.env['devise.mapping'] = Devise.mappings[:user]
+  env = OmniAuth::AuthHash.new(
+                                provider: 'google',
+                                uid: 'google-test-uid-1',
+                                info: {
+                                  name: 'google user',
+                                  email: nil,
+                                  username: 'user_google'
+                                },
+                                credentials: {
+                                  token: 'google_mock_token',
+                                  secret: 'google_mock_secret'
+                                }
+  )
+  request.env['omniauth.auth'] = env
+  @controller.stub(:env).and_return(env)
+end