Fix Rubocop issues

Gemfile

@@ -116,8 +116,8 @@ end
 gem 'bootstrap3-datetimepicker-rails', '~> 4.17.47'
 
 # data tables
-gem 'jquery-datatables'
 gem 'ajax-datatables-rails'
+gem 'jquery-datatables'
 
 # for charts
 gem 'chartkick'

app/controllers/admin/reports_controller.rb

@@ -9,7 +9,7 @@ module Admin
 
     def index
       @events = Event.accessible_by(current_ability).where(program: @program,
-                                                           state: [:confirmed, :unconfirmed])
+                                                           state:   [:confirmed, :unconfirmed])
       @events_commercials = Commercial.where(commercialable_type: 'Event', commercialable_id: @events.pluck(:id))
       @events_missing_commercial = @events.where.not(id: @events_commercials.pluck(:commercialable_id))
       @events_with_requirements = @events.where.not(description: ['', nil])

app/controllers/application_controller.rb

@@ -10,22 +10,22 @@ class ApplicationController < ActionController::Base
   check_authorization unless: :devise_controller?
   skip_authorization_check if:
 
-  def store_location
+                               def store_location
-    # store last url - this is needed for post-login redirect to whatever the user last visited.
+                                 # store last url - this is needed for post-login redirect to whatever the user last visited.
-    return unless request.get?
+                                 return unless request.get?
 
-    if (request.path != '/accounts/sign_in' &&
+                                 if (request.path != '/accounts/sign_in' &&
-        request.path != '/accounts/sign_up' &&
+                                     request.path != '/accounts/sign_up' &&
-        request.path != '/accounts/password/new' &&
+                                     request.path != '/accounts/password/new' &&
-        request.path != '/accounts/password/edit' &&
+                                     request.path != '/accounts/password/edit' &&
-        request.path != '/accounts/confirmation' &&
+                                     request.path != '/accounts/confirmation' &&
-        request.path != '/accounts/sign_out' &&
+                                     request.path != '/accounts/sign_out' &&
-        request.path != '/users/ichain_registration/ichain_sign_up' &&
+                                     request.path != '/users/ichain_registration/ichain_sign_up' &&
-        !request.path.starts_with?(Devise.ichain_base_url) &&
+                                     !request.path.starts_with?(Devise.ichain_base_url) &&
-        !request.xhr?) # don't store ajax calls
+                                     !request.xhr?) # don't store ajax calls
-      session[:return_to] = request.fullpath
+                                   session[:return_to] = request.fullpath
-    end
+                                 end
-  end
+                               end
 
   def after_sign_in_path_for(_resource)
     if (can? :view, Conference) &&

app/controllers/users_controller.rb

@@ -27,11 +27,13 @@ class UsersController < ApplicationController
 
   def user_params
     params.require(:user).permit(:name, :biography, :nickname, :affiliation,
-                                  :picture, :picture_cache)
+                                 :picture, :picture_cache)
   end
 
   # Somewhat of a hack: users/current/edit
+  # rubocop:disable Naming/MemoizedInstanceVariableName
   def load_user
     @user ||= (params[:id] && params[:id] != 'current' && User.find(params[:id]) || current_user)
   end
+  # rubocop:enable Naming/MemoizedInstanceVariableName
 end

app/datatables/user_datatable.rb

@@ -1,4 +1,3 @@
-
 # frozen_string_literal: true
 
 class UserDatatable < AjaxDatatablesRails::Base

app/helpers/application_helper.rb

@@ -112,7 +112,7 @@ module ApplicationHelper
         concurrent_events << other_event_schedule.event
       end
     end
-    concurrent_events.sort_by { |event_schedule| event_schedule.room&.order }
+    concurrent_events.sort_by { |schedule| schedule.room&.order }
   end
 
   def speaker_links(event)
@@ -188,7 +188,7 @@ module ApplicationHelper
     'hidden' if Date.today > conference.end_date
   end
 
-  # TODO:Snap!Con: Replace this with a search for a conference logo.
+  # TODO: Snap!Con: Replace this with a search for a conference logo.
   def nav_root_link_for(conference = nil)
     path = conference&.id.present? ? conference_path(conference) : root_path
     link_to(
@@ -201,8 +201,8 @@ module ApplicationHelper
 
   def nav_link_text(conference)
     conference.try(:organization).try(:name) ||
-    ENV['OSEM_NAME'] ||
+      ENV['OSEM_NAME'] ||
-    'OSEM'
+      'OSEM'
   end
 
   # returns the url to be used for logo on basis of sponsorship level position

app/helpers/conference_helper.rb

@@ -24,6 +24,7 @@ module ConferenceHelper
 
   def short_ticket_description(ticket)
     return unless ticket.description
+
     markdown(ticket.description.split("\n").first&.strip)
   end
 end

app/helpers/events_helper.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+# TODO: Split this module into smaller modules
+# rubocop:disable Metrics/ModuleLength
 module EventsHelper
   ##
   # Includes functions related to events
@@ -164,7 +166,7 @@ module EventsHelper
       conference_id,
       event.id,
       event.send(attribute),
-      url: admin_conference_program_event_path(
+      url:   admin_conference_program_event_path(
         conference_id,
         event,
         event: { attribute => nil }
@@ -183,7 +185,7 @@ module EventsHelper
     if current_user.roles.where(id: conference.roles).any?
       # Show Pre-Event links for any memeber of the conference team.
       link_to("Join Live Event #{'(Admin link)' unless is_now}",
-                      event.url, target: '_blank')
+              event.url, target: '_blank')
     elsif current_user.registered_to_event?(conference)
       if is_now
         link_to('Join Live Event', event.url, target: '_blank')
@@ -193,7 +195,7 @@ module EventsHelper
     end
   end
 
-  def calendar_timestamp(timestamp, timezone)
+  def calendar_timestamp(timestamp, _timezone)
     timestamp = timestamp.in_time_zone('GMT')
     timestamp -= timestamp.utc_offset
     timestamp.strftime('%Y%m%dT%H%M%S')
@@ -206,12 +208,12 @@ module EventsHelper
     start_timestamp = calendar_timestamp(event_schedule.start_time, conference.timezone)
     end_timestamp = calendar_timestamp(event_schedule.end_time, conference.timezone)
     event_details = {
-      action: 'TEMPLATE',
+      action:   'TEMPLATE',
-      text: "#{event.title} at #{conference.title}",
+      text:     "#{event.title} at #{conference.title}",
-      details: calendar_event_text(event, event_schedule, conference),
+      details:  calendar_event_text(event, event_schedule, conference),
       location: "#{event.room.name} #{event.url}",
-      dates: "#{start_timestamp}/#{end_timestamp}",
+      dates:    "#{start_timestamp}/#{end_timestamp}",
-      ctz: event_schedule.timezone
+      ctz:      event_schedule.timezone
     }
     "#{calendar_base}?#{event_details.to_param}"
   end
@@ -220,13 +222,13 @@ module EventsHelper
 
   def calendar_event_text(event, event_schedule, conference)
     <<~TEXT
-    #{conference.title} - #{event.title}
+      #{conference.title} - #{event.title}
-    #{event_schedule.start_time.strftime("%Y %B %e - %H:%M")} #{event_schedule.timezone}
+      #{event_schedule.start_time.strftime('%Y %B %e - %H:%M')} #{event_schedule.timezone}
 
-    More Info: #{conference_program_proposal_url(conference, event)}
+      More Info: #{conference_program_proposal_url(conference, event)}
-    Join: #{event.url}
+      Join: #{event.url}
 
-    #{truncate(event.abstract, length: 200)}
+      #{truncate(event.abstract, length: 200)}
     TEXT
   end
 
@@ -256,3 +258,4 @@ module EventsHelper
     end
   end
 end
+# rubocop:enable Metrics/ModuleLength

app/helpers/format_helper.rb

@@ -184,12 +184,12 @@ module FormatHelper
     return '' if text.nil?
 
     options = {
-      autolink: true,
+      autolink:            true,
       space_after_headers: true,
-      tables: true,
+      tables:              true,
-      strikethrough: true,
+      strikethrough:       true,
-      footnotes: true,
+      footnotes:           true,
-      superscript: true
+      superscript:         true
     }
     markdown = Redcarpet::Markdown.new(Redcarpet::Render::HTML.new(escape_html: escape_html), options)
     markdown.render(text).html_safe

app/models/ability.rb

@@ -68,6 +68,8 @@ class Ability
   end
 
   # Abilities for signed in users
+  # TODO: Refactor into multiple functions
+  # rubocop:disable Metrics/AbcSize
   def signed_in(user)
     # Abilities from not_signed_in user are also inherited
     not_signed_in
@@ -140,6 +142,7 @@ class Ability
       user == track.submitter && !(track.accepted? || track.confirmed?)
     end
   end
+  # rubocop:enable Metrics/AbcSize
 
   # Abilities for users with roles wandering around in non-admin views.
   def common_abilities_for_admins(user)

app/models/commercial.rb

@@ -17,7 +17,7 @@ class Commercial < ApplicationRecord
     begin
       resource = OEmbed::Providers.get(url, maxwidth: 560, maxheight: 315)
       { html: resource.html.html_safe }
-    rescue StandardError => exception
+    rescue StandardError
       { html: iframe_fallback(url) }
       # { error: exception.message }
     end

app/models/conference.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# rubocop:disable Metrics/ClassLength
 class Conference < ApplicationRecord
   include RevisionCount
   require 'uri'
@@ -1199,3 +1200,4 @@ class Conference < ApplicationRecord
     ]
   end
 end
+# rubocop:enable Metrics/ClassLength

app/models/event.rb

@@ -281,7 +281,6 @@ class Event < ApplicationRecord
     event_schedules.find_by(schedule_id: selected_schedule_id).try(:happening_now?)
   end
 
-
   ##
   # Returns true or false, if the event is already over or not
   #

app/models/event_user.rb

@@ -2,7 +2,7 @@
 
 class EventUser < ApplicationRecord
   ROLES = [%w[Speaker speaker], %w[Submitter submitter], %w[Moderator moderator],
-            %w[Volunteer volunteer]]
+           %w[Volunteer volunteer]]
 
   belongs_to :event, touch: true
   belongs_to :user

app/models/payment.rb

@@ -23,7 +23,7 @@ class Payment < ApplicationRecord
   end
 
   def stripe_description
-    #"ticket purchases(#{user.username})"
+    # "ticket purchases(#{user.username})"
     "Tickets for #{conference.title} #{user.name} #{user.email}"
   end
 

app/models/ticket_purchase.rb

@@ -107,6 +107,7 @@ end
 def count_purchased_registration_tickets(conference, purchases)
   # TODO: WHAT CAUSED THIS???
   return 0 unless purchases
+
   conference.tickets.for_registration.inject(0) do |sum, registration_ticket|
     sum + purchases[registration_ticket.id.to_s].to_i
   end

app/models/user.rb

@@ -56,8 +56,7 @@ class User < ApplicationRecord
                        :recoverable, :rememberable, :trackable, :validatable, :confirmable,
                        :omniauthable,
                        # omniauth_providers: [:suse, :google, :facebook, :github, :discourse]
-                       omniauth_providers: [:google, :discourse]
+                       omniauth_providers: [:google, :discourse]]
-                      ]
                     end
 
   devise(*devise_modules)
@@ -160,6 +159,7 @@ class User < ApplicationRecord
   # Partials should *not* directly call `gravatar_url`
   def profile_picture(opts = {})
     return gravatar_url(opts) unless picture.present?
+
     size = (opts[:size] || 0).to_i
     if size < 50
       picture.tiny.url
@@ -259,7 +259,7 @@ class User < ApplicationRecord
   # TODO: Use a real authorization in the right place....
   def manages_volunteers?(conference)
     organizer_roles = get_roles['organizer']
-    organizer_roles&.include?(conference.short_title) # TODO or Volunteer Coorinator.
+    organizer_roles&.include?(conference.short_title) # TODO: or Volunteer Coorinator.
   end
 
   def registered
@@ -300,7 +300,6 @@ class User < ApplicationRecord
     events.where(program_id: conference.program.id, 'event_users.event_role': 'volunteer')
   end
 
-
   def self.empty?
     User.count == 1 && User.first.email == 'deleted@localhost.osem'
   end

config/application.rb

@@ -68,9 +68,11 @@ module Osem
 
     config.before_configuration do
       env_file = File.join(Rails.root, 'config', 'local_env.yml')
-      YAML.load(File.open(env_file)).each do |key, value|
+      if File.exist?(env_file)
-        ENV[key.to_s] = value
+        YAML.safe_load(File.open(env_file)).each do |key, value|
-      end if File.exists?(env_file)
+          ENV[key.to_s] = value
+        end
+      end
     end
   end
 end

config/initializers/devise.rb

@@ -15,7 +15,7 @@ Devise.setup do |config|
                   scope: 'email'
 
   config.omniauth :discourse,
-                  sso_url: 'https://forum.snap.berkeley.edu/session/sso_provider',
+                  sso_url:    'https://forum.snap.berkeley.edu/session/sso_provider',
                   sso_secret: ENV['OSEM_DISCOURSE_SECRET']
 
   config.omniauth :facebook,

config/puma.rb

@@ -46,9 +46,9 @@ end
 lowlevel_error_handler do |ex, env|
   Raven.capture_exception(
     ex,
-    :message => ex.message,
+    message:     ex.message,
-    :extra => { :puma => env },
+    extra:       { puma: env },
-    :transaction => "Puma"
+    transaction: "Puma"
   )
   # note the below is just a Rack response
   [500, {}, ["An error has occurred, and engineers have been informed. Please reload the page. If you continue to have problems, contact conference@snap.berkeley.edu\n"]]

config/routes.rb

@@ -1,6 +1,6 @@
 Osem::Application.routes.draw do
 
-  mount LetterOpenerWeb::Engine, at: "/letter_opener" if Rails.env.development?
+  mount LetterOpenerWeb::Engine, at: '/letter_opener' if Rails.env.development?
 
   if ENV['OSEM_ICHAIN_ENABLED'] == 'true'
     devise_for :users, controllers: { registrations: :registrations }

db/migrate/20180409170433_add_visible_to_tickets.rb

@@ -2,7 +2,7 @@ class AddVisibleToTickets < ActiveRecord::Migration[5.0]
   def up
     add_column :tickets, :visible, :boolean, default: true
     Ticket.reset_column_information
-    Ticket.update_all(visible: true) # rubocop:disable Rails/SkipsModelValidations
+    Ticket.update_all(visible: true)
   end
 
   def down

lib/tasks/db.rake

@@ -13,24 +13,24 @@ namespace :db do
     end
   end
 
-  desc "Import a given file into the database"
+  desc 'Import a given file into the database'
   task :import, [:path] => :environment do |_t, args|
     dump_path = args.path
     connection_config = ActiveRecord::Base.connection_config
 
     case connection_config[:adapter]
-    when "postgresql"
+    when 'postgresql'
       system("PGPASSWORD=#{connection_config[:password]} pg_restore " \
-        "--verbose --clean --no-acl --no-owner " \
+        '--verbose --clean --no-acl --no-owner ' \
         "--username=#{connection_config[:username]} " \
         "-d #{connection_config[:database]} #{dump_path}")
-    when "mysql", "mysql2"
+    when 'mysql', 'mysql2'
       system("mysql -u #{connection_config[:username]} " \
         "-p#{connection_config[:password]} " \
         "#{connection_config[:database]} < #{dump_path}")
     else
-      raise NotImplementedError, "An importer hasn't been implemented for: " \
+      raise NotImplementedError.new("An importer hasn't been implemented for: " \
-        "#{connection_config[:adapter]}"
+        "#{connection_config[:adapter]}")
     end
   end
 end

lib/tasks/registrations.rake

@@ -1,17 +1,17 @@
 # frozen_string_literal: true
 
 namespace :registrations do
-  desc "Create missing registrations for those how have a registration ticket."
+  desc 'Create missing registrations for those how have a registration ticket.'
-  task :create_missing, [:conference] => :environment do |t, args|
+  task :create_missing, [:conference] => :environment do |_t, args|
 
-    fail 'Please supply a conference short name.' unless args.conference
+    raise 'Please supply a conference short name.' unless args.conference
 
     conf = Conference.find_by(short_title: args.conference)
     # Check if a user is found based on the supplied email address
-    fail "Coud not find conference #{args.conference}" unless conf
+    raise "Coud not find conference #{args.conference}" unless conf
 
     purchases = conf.ticket_purchases.where(ticket: conf.registration_tickets, paid: true)
-    unregistered = purchases.select { |tp| !conf.user_registered?(tp.user) }
+    unregistered = purchases.reject { |tp| conf.user_registered?(tp.user) }
     puts "Found #{unregistered.count} unregistered users for #{purchases.count} ticket purchases."
     puts "There are currently #{conf.participants.count} registered users."
 
@@ -19,17 +19,17 @@ namespace :registrations do
       puts "Creating registration for #{tp.user.email}"
       Registration.create(user: tp.user, conference: conf)
     end
-    puts "Done."
+    puts 'Done.'
   end
 
-  desc "Show User emails who have not paid, but did register"
+  desc 'Show User emails who have not paid, but did register'
-  task :list_unpaid, [:conference] => :environment do |t, args|
+  task :list_unpaid, [:conference] => :environment do |_t, args|
 
-    fail 'Please supply a conference short name.' unless args.conference
+    raise 'Please supply a conference short name.' unless args.conference
 
     conf = Conference.find_by(short_title: args.conference)
     # Check if a user is found based on the supplied email address
-    fail "Coud not find conference #{args.conference}" unless conf
+    raise "Coud not find conference #{args.conference}" unless conf
 
     registered = conf.participants
     unpaid = registered.select do |user|
@@ -41,6 +41,6 @@ namespace :registrations do
     unpaid.each do |user|
       puts "'#{user.name}'<#{user.email}>, "
     end
-    puts ""
+    puts ''
   end
 end

spec/controllers/admin/tickets_controller_spec.rb

@@ -69,8 +69,8 @@ describe Admin::TicketsController do
         it 'creates new ticket' do
           expect do
             post :create, params: {
-                ticket: attributes_for(:ticket),
+              ticket:        attributes_for(:ticket),
-                conference_id: conference
+              conference_id: conference
             }
           end.to change{ conference.tickets.count }.from(ticket_count).to(ticket_count + 1)
         end

spec/helpers/application_helper_spec.rb

@@ -65,7 +65,7 @@ describe ApplicationHelper, type: :helper do
     describe 'navigation title link' do
       it 'should default to OSEM' do
         ENV.delete('OSEM_NAME')
-        # TODO:Snap!Con: expect(nav_root_link_for(nil)).to match 'OSEM'
+        # TODO: Snap!Con: expect(nav_root_link_for(nil)).to match 'OSEM'
         expect(nav_root_link_for(nil)).to match image_tag('snapcon_logo.png')
       end
 

spec/helpers/format_helper_spec.rb

@@ -13,12 +13,12 @@ describe FormatHelper, type: :helper do
       expect(Redcarpet::Markdown).to receive(:new)
       .with(
         Redcarpet::Render::HTML,
-        autolink: true,
+        autolink:            true,
         space_after_headers: true,
-        tables: true,
+        tables:              true,
-        strikethrough: true,
+        strikethrough:       true,
-        footnotes: true,
+        footnotes:           true,
-        superscript: true
+        superscript:         true
       )
       .and_call_original