Merge master
This commit is contained in:
commit
7586112f72
217 changed files with 2853 additions and 3035 deletions
|
|
@ -1,12 +1,13 @@
|
|||
# This configuration was generated by
|
||||
# `rubocop --auto-gen-config`
|
||||
# on 2018-09-08 03:47:39 +0200 using RuboCop version 0.58.2.
|
||||
# on 2019-10-16 20:30:53 -0700 using RuboCop version 0.75.1.
|
||||
# The point is for the user to remove these configuration records
|
||||
# one by one as the offenses are removed from the code base.
|
||||
# Note that changes in the inspected code, or installation of new
|
||||
# versions of RuboCop, may require this file to be generated again.
|
||||
|
||||
# Offense count: 381
|
||||
# Offense count: 351
|
||||
# Cop supports --auto-correct.
|
||||
Capybara/CurrentPathExpectation:
|
||||
Exclude:
|
||||
- 'spec/features/base_controller_spec.rb'
|
||||
|
|
@ -23,25 +24,12 @@ Capybara/CurrentPathExpectation:
|
|||
- 'spec/features/track_organizer_ability_spec.rb'
|
||||
- 'spec/features/user_ability_spec.rb'
|
||||
|
||||
# Offense count: 170
|
||||
# Offense count: 161
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnabledMethods.
|
||||
Capybara/FeatureMethods:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 140
|
||||
# Cop supports --auto-correct.
|
||||
FactoryBot/AttributeDefinedStatically:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
||||
# SupportedStyles: with_first_parameter, with_fixed_indentation
|
||||
Layout/AlignParameters:
|
||||
Exclude:
|
||||
- 'Vagrantfile'
|
||||
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
Layout/ClosingParenthesisIndentation:
|
||||
|
|
@ -75,7 +63,7 @@ Layout/EmptyLineAfterMagicComment:
|
|||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 121
|
||||
# Offense count: 118
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: empty_lines, no_empty_lines
|
||||
|
|
@ -88,9 +76,9 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
|
|||
Exclude:
|
||||
- 'app/models/payment.rb'
|
||||
|
||||
# Offense count: 51
|
||||
# Offense count: 14
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
|
||||
# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
|
||||
Layout/ExtraSpacing:
|
||||
Exclude:
|
||||
- 'Guardfile'
|
||||
|
|
@ -103,52 +91,49 @@ Layout/ExtraSpacing:
|
|||
- 'db/migrate/20140623101032_create_ahoy_events.rb'
|
||||
- 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
|
||||
- 'db/migrate/20140719160903_create_delayed_jobs.rb'
|
||||
- 'db/schema.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 47
|
||||
# Offense count: 5
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IndentationWidth.
|
||||
Layout/IndentAssignment:
|
||||
Exclude:
|
||||
- 'app/helpers/format_helper.rb'
|
||||
- 'config/environments/development.rb'
|
||||
|
||||
# Offense count: 43
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
||||
# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
|
||||
Layout/FirstParameterIndentation:
|
||||
Layout/IndentFirstArgument:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
||||
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
|
||||
Layout/IndentArray:
|
||||
Layout/IndentFirstArrayElement:
|
||||
Exclude:
|
||||
- 'app/models/conference.rb'
|
||||
|
||||
# Offense count: 6
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IndentationWidth.
|
||||
Layout/IndentAssignment:
|
||||
Exclude:
|
||||
- 'app/helpers/format_helper.rb'
|
||||
- 'app/models/conference.rb'
|
||||
- 'config/environments/development.rb'
|
||||
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, IndentationWidth.
|
||||
# SupportedStyles: special_inside_parentheses, consistent, align_braces
|
||||
Layout/IndentHash:
|
||||
Layout/IndentFirstHashElement:
|
||||
Exclude:
|
||||
- 'app/models/user.rb'
|
||||
- 'config/routes.rb'
|
||||
- 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: normal, rails
|
||||
# SupportedStyles: normal, indented_internal_methods
|
||||
Layout/IndentationConsistency:
|
||||
Exclude:
|
||||
- 'app/controllers/users_controller.rb'
|
||||
- 'app/models/event.rb'
|
||||
- 'spec/controllers/subscriptions_controller_spec.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
|
|
@ -157,13 +142,13 @@ Layout/IndentationWidth:
|
|||
Exclude:
|
||||
- 'app/controllers/users_controller.rb'
|
||||
|
||||
# Offense count: 5
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowDoxygenCommentStyle.
|
||||
Layout/LeadingCommentSpace:
|
||||
Exclude:
|
||||
- 'Guardfile'
|
||||
- 'app/models/comment.rb'
|
||||
- 'config/deploy.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
|
|
@ -189,7 +174,7 @@ Layout/MultilineHashBraceLayout:
|
|||
- 'config/routes.rb'
|
||||
- 'spec/models/event_spec.rb'
|
||||
|
||||
# Offense count: 40
|
||||
# Offense count: 36
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: symmetrical, new_line, same_line
|
||||
|
|
@ -252,7 +237,7 @@ Layout/SpaceAroundOperators:
|
|||
- 'config/initializers/airbrake.rb'
|
||||
- 'lib/tasks/data.rake'
|
||||
|
||||
# Offense count: 487
|
||||
# Offense count: 138
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
|
||||
# SupportedStyles: space, no_space
|
||||
|
|
@ -302,20 +287,19 @@ Layout/SpaceInsideBlockBraces:
|
|||
- 'app/models/ticket.rb'
|
||||
- 'app/models/user.rb'
|
||||
- 'lib/tasks/events_registrations.rake'
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/controllers/admin/event_schedules_controller_spec.rb'
|
||||
- 'spec/controllers/admin/schedules_controller_spec.rb'
|
||||
- 'spec/features/splashpage_spec.rb'
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/user_spec.rb'
|
||||
|
||||
# Offense count: 39
|
||||
# Offense count: 37
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
|
||||
# SupportedStyles: space, no_space, compact
|
||||
# SupportedStylesForEmptyBraces: space, no_space
|
||||
Layout/SpaceInsideHashLiteralBraces:
|
||||
Exclude:
|
||||
- 'app/controllers/admin/conferences_controller.rb'
|
||||
- 'app/controllers/api/v1/speakers_controller.rb'
|
||||
- 'app/models/conference.rb'
|
||||
- 'app/models/event_type.rb'
|
||||
|
|
@ -339,15 +323,13 @@ Layout/SpaceInsideParens:
|
|||
Exclude:
|
||||
- 'app/views/admin/registrations/index.xlsx.axlsx'
|
||||
|
||||
# Offense count: 5
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
Layout/SpaceInsidePercentLiteralDelimiters:
|
||||
Exclude:
|
||||
- 'Gemfile'
|
||||
- 'config/deploy.rb'
|
||||
- 'config/initializers/assets.rb'
|
||||
|
||||
# Offense count: 2
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: space, no_space
|
||||
|
|
@ -355,6 +337,13 @@ Layout/SpaceInsideStringInterpolation:
|
|||
Exclude:
|
||||
- 'config/initializers/active_record_log_subscriber.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IndentationWidth.
|
||||
Layout/Tab:
|
||||
Exclude:
|
||||
- 'app/controllers/admin/resources_controller.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
|
|
@ -389,6 +378,7 @@ Lint/DuplicatedKey:
|
|||
- 'db/migrate/20140801170430_move_event_media_to_commercial.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: AllowComments.
|
||||
Lint/HandleExceptions:
|
||||
Exclude:
|
||||
- 'bin/rspec'
|
||||
|
|
@ -406,6 +396,12 @@ Lint/ScriptPermission:
|
|||
- 'Guardfile'
|
||||
- 'Rakefile'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
Lint/SendWithMixinArgument:
|
||||
Exclude:
|
||||
- 'config/initializers/active_record_log_subscriber.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
|
||||
|
|
@ -420,15 +416,15 @@ Lint/UnusedMethodArgument:
|
|||
Exclude:
|
||||
- 'config/initializers/fuckups.rb'
|
||||
|
||||
# Offense count: 142
|
||||
# Offense count: 139
|
||||
Metrics/AbcSize:
|
||||
Max: 94
|
||||
Max: 70
|
||||
|
||||
# Offense count: 331
|
||||
# Offense count: 314
|
||||
# Configuration parameters: CountComments, ExcludedMethods.
|
||||
# ExcludedMethods: refine
|
||||
Metrics/BlockLength:
|
||||
Max: 1419
|
||||
Max: 1344
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: CountBlocks.
|
||||
|
|
@ -438,16 +434,16 @@ Metrics/BlockNesting:
|
|||
# Offense count: 13
|
||||
# Configuration parameters: CountComments.
|
||||
Metrics/ClassLength:
|
||||
Max: 684
|
||||
Max: 650
|
||||
|
||||
# Offense count: 32
|
||||
# Offense count: 33
|
||||
Metrics/CyclomaticComplexity:
|
||||
Max: 14
|
||||
|
||||
# Offense count: 146
|
||||
# Configuration parameters: CountComments.
|
||||
# Offense count: 147
|
||||
# Configuration parameters: CountComments, ExcludedMethods.
|
||||
Metrics/MethodLength:
|
||||
Max: 60
|
||||
Max: 56
|
||||
|
||||
# Offense count: 5
|
||||
# Configuration parameters: CountComments.
|
||||
|
|
@ -458,7 +454,7 @@ Metrics/ModuleLength:
|
|||
Metrics/PerceivedComplexity:
|
||||
Max: 16
|
||||
|
||||
# Offense count: 17
|
||||
# Offense count: 13
|
||||
Naming/AccessorMethodName:
|
||||
Exclude:
|
||||
- 'app/models/conference.rb'
|
||||
|
|
@ -484,9 +480,17 @@ Naming/PredicateName:
|
|||
- 'app/models/comment.rb'
|
||||
- 'app/models/contact.rb'
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: PreferredName.
|
||||
Naming/RescuedExceptionsVariableName:
|
||||
Exclude:
|
||||
- 'app/models/commercial.rb'
|
||||
- 'app/models/payment.rb'
|
||||
|
||||
# Offense count: 2
|
||||
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
|
||||
# AllowedNames: io, id, to, by, on, in, at, ip
|
||||
# AllowedNames: io, id, to, by, on, in, at, ip, db
|
||||
Naming/UncommunicativeMethodParamName:
|
||||
Exclude:
|
||||
- 'app/models/conference.rb'
|
||||
|
|
@ -498,14 +502,7 @@ Naming/VariableNumber:
|
|||
Exclude:
|
||||
- 'spec/models/ticket_purchase_spec.rb'
|
||||
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
Performance/InefficientHashSearch:
|
||||
Exclude:
|
||||
- 'app/controllers/admin/versions_controller.rb'
|
||||
- 'app/helpers/versions_helper.rb'
|
||||
|
||||
# Offense count: 31
|
||||
# Offense count: 28
|
||||
RSpec/AnyInstance:
|
||||
Exclude:
|
||||
- 'spec/controllers/admin/rooms_controller_spec.rb'
|
||||
|
|
@ -517,7 +514,7 @@ RSpec/AnyInstance:
|
|||
- 'spec/controllers/proposals_controller_spec.rb'
|
||||
- 'spec/controllers/tracks_controller_spec.rb'
|
||||
|
||||
# Offense count: 327
|
||||
# Offense count: 317
|
||||
# Configuration parameters: Prefixes.
|
||||
# Prefixes: when, with, without
|
||||
RSpec/ContextWording:
|
||||
|
|
@ -538,6 +535,24 @@ RSpec/DescribedClass:
|
|||
- 'spec/models/ticket_purchase_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
- 'spec/models/user_spec.rb'
|
||||
- 'spec/serializers/conference_serializer_spec.rb'
|
||||
- 'spec/serializers/event_serializer_spec.rb'
|
||||
- 'spec/serializers/room_serializer_spec.rb'
|
||||
- 'spec/serializers/speaker_serializer_spec.rb'
|
||||
- 'spec/serializers/track_serializer_spec.rb'
|
||||
|
||||
# Offense count: 13
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AllowConsecutiveOneLiners.
|
||||
RSpec/EmptyLineAfterExample:
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/controllers/admin/comments_controller_spec.rb'
|
||||
- 'spec/controllers/admin/registration_periods_controller_spec.rb'
|
||||
- 'spec/controllers/admin/users_controller_spec.rb'
|
||||
- 'spec/helpers/events_helper_spec.rb'
|
||||
- 'spec/models/event_spec.rb'
|
||||
- 'spec/models/survey_spec.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
|
|
@ -545,7 +560,7 @@ RSpec/EmptyLineAfterExampleGroup:
|
|||
Exclude:
|
||||
- 'spec/controllers/admin/users_controller_spec.rb'
|
||||
|
||||
# Offense count: 12
|
||||
# Offense count: 11
|
||||
# Cop supports --auto-correct.
|
||||
RSpec/EmptyLineAfterFinalLet:
|
||||
Exclude:
|
||||
|
|
@ -553,7 +568,6 @@ RSpec/EmptyLineAfterFinalLet:
|
|||
- 'spec/controllers/admin/users_controller_spec.rb'
|
||||
- 'spec/controllers/application_controller_spec.rb'
|
||||
- 'spec/features/conference_spec.rb'
|
||||
- 'spec/models/admin_ability_spec.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/payment_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
|
|
@ -573,12 +587,11 @@ RSpec/EmptyLineAfterHook:
|
|||
- 'spec/models/payment_spec.rb'
|
||||
- 'spec/models/program_spec.rb'
|
||||
|
||||
# Offense count: 9
|
||||
# Offense count: 8
|
||||
# Cop supports --auto-correct.
|
||||
RSpec/EmptyLineAfterSubject:
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/admin_ability_spec.rb'
|
||||
- 'spec/models/booth_spec.rb'
|
||||
- 'spec/models/cfp_spec.rb'
|
||||
- 'spec/models/event_spec.rb'
|
||||
|
|
@ -587,7 +600,7 @@ RSpec/EmptyLineAfterSubject:
|
|||
- 'spec/models/survey_spec.rb'
|
||||
- 'spec/models/track_spec.rb'
|
||||
|
||||
# Offense count: 230
|
||||
# Offense count: 220
|
||||
# Configuration parameters: Max.
|
||||
RSpec/ExampleLength:
|
||||
Enabled: false
|
||||
|
|
@ -608,7 +621,7 @@ RSpec/ExampleWording:
|
|||
- 'spec/models/ticket_purchase_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
|
||||
# Offense count: 38
|
||||
# Offense count: 37
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: method_call, block
|
||||
|
|
@ -638,28 +651,41 @@ RSpec/FilePath:
|
|||
- 'spec/models/comment_spec.rb'
|
||||
- 'spec/models/openid.rb'
|
||||
|
||||
# Offense count: 174
|
||||
# Offense count: 171
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: implicit, each, example
|
||||
RSpec/HookArgument:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 499
|
||||
# Offense count: 140
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: is_expected, should
|
||||
RSpec/ImplicitExpect:
|
||||
Enabled: false
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/commercial_spec.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/event_schedule_spec.rb'
|
||||
- 'spec/models/event_type_spec.rb'
|
||||
- 'spec/models/organization_spec.rb'
|
||||
- 'spec/models/registration_period_spec.rb'
|
||||
- 'spec/models/room_spec.rb'
|
||||
- 'spec/models/schedule_spec.rb'
|
||||
- 'spec/models/sponsor_spec.rb'
|
||||
- 'spec/models/sponsorship_level_spec.rb'
|
||||
- 'spec/models/ticket_purchase_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
- 'spec/models/user_spec.rb'
|
||||
|
||||
# Offense count: 48
|
||||
# Offense count: 39
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: single_line_only, disallow
|
||||
# SupportedStyles: single_line_only, single_statement_only, disallow
|
||||
RSpec/ImplicitSubject:
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/admin_ability_spec.rb'
|
||||
- 'spec/models/booth_spec.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/event_type_spec.rb'
|
||||
|
|
@ -670,21 +696,35 @@ RSpec/ImplicitSubject:
|
|||
- 'spec/models/ticket_purchase_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
|
||||
# Offense count: 347
|
||||
# Offense count: 321
|
||||
# Configuration parameters: AssignmentOnly.
|
||||
RSpec/InstanceVariable:
|
||||
Enabled: false
|
||||
Exclude:
|
||||
- 'spec/controllers/admin/sponsorship_levels_controller_spec.rb'
|
||||
- 'spec/controllers/admin/versions_controller_spec.rb'
|
||||
- 'spec/controllers/api/v1/conferences_controller_spec.rb'
|
||||
- 'spec/controllers/application_controller_spec.rb'
|
||||
- 'spec/controllers/conference_registration_controller_spec.rb'
|
||||
- 'spec/controllers/conferences_controller_spec.rb'
|
||||
- 'spec/controllers/confirmations_controller_spec.rb'
|
||||
- 'spec/controllers/proposals_controller_spec.rb'
|
||||
- 'spec/features/proposals_spec.rb'
|
||||
- 'spec/helpers/application_helper_spec.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/event_schedule_spec.rb'
|
||||
- 'spec/models/sponsorship_level_spec.rb'
|
||||
- 'spec/models/track_spec.rb'
|
||||
- 'spec/models/user_spec.rb'
|
||||
|
||||
# Offense count: 5
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
RSpec/LeadingSubject:
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/admin_ability_spec.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/ticket_spec.rb'
|
||||
|
||||
# Offense count: 51
|
||||
# Offense count: 55
|
||||
RSpec/LetSetup:
|
||||
Enabled: false
|
||||
|
||||
|
|
@ -699,12 +739,13 @@ RSpec/MultipleDescribes:
|
|||
Exclude:
|
||||
- 'spec/controllers/application_controller_spec.rb'
|
||||
|
||||
# Offense count: 283
|
||||
# Offense count: 278
|
||||
# Configuration parameters: AggregateFailuresByDefault.
|
||||
RSpec/MultipleExpectations:
|
||||
Max: 106
|
||||
Max: 97
|
||||
|
||||
# Offense count: 403
|
||||
# Offense count: 387
|
||||
# Configuration parameters: IgnoreSharedExamples.
|
||||
RSpec/NamedSubject:
|
||||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
|
@ -712,11 +753,11 @@ RSpec/NamedSubject:
|
|||
- 'spec/models/room_spec.rb'
|
||||
- 'spec/models/track_spec.rb'
|
||||
|
||||
# Offense count: 213
|
||||
# Offense count: 206
|
||||
RSpec/NestedGroups:
|
||||
Max: 7
|
||||
|
||||
# Offense count: 93
|
||||
# Offense count: 85
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: not_to, to_not
|
||||
|
|
@ -746,7 +787,7 @@ RSpec/RepeatedExample:
|
|||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 13
|
||||
# Offense count: 10
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: and_return, block
|
||||
|
|
@ -754,11 +795,10 @@ RSpec/ReturnFromStub:
|
|||
Exclude:
|
||||
- 'spec/helpers/events_helper_spec.rb'
|
||||
|
||||
# Offense count: 49
|
||||
# Offense count: 19
|
||||
RSpec/ScatteredLet:
|
||||
Exclude:
|
||||
- 'spec/ability/ability_spec.rb'
|
||||
- 'spec/models/admin_ability_spec.rb'
|
||||
- 'spec/models/payment_spec.rb'
|
||||
|
||||
# Offense count: 2
|
||||
|
|
@ -773,8 +813,8 @@ RSpec/SubjectStub:
|
|||
- 'spec/models/room_spec.rb'
|
||||
- 'spec/models/track_spec.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: IgnoreSymbolicNames.
|
||||
# Offense count: 3
|
||||
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
|
||||
RSpec/VerifiedDoubles:
|
||||
Exclude:
|
||||
- 'spec/datatables/user_datatable_spec.rb'
|
||||
|
|
@ -785,247 +825,11 @@ RSpec/VoidExpect:
|
|||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, Include.
|
||||
# SupportedStyles: action, filter
|
||||
# Include: app/controllers/**/*.rb
|
||||
Rails/ActionFilter:
|
||||
Exclude:
|
||||
- 'app/controllers/users/omniauth_callbacks_controller.rb'
|
||||
|
||||
# Offense count: 107
|
||||
# Cop supports --auto-correct.
|
||||
Rails/ActiveRecordAliases:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 128
|
||||
# Cop supports --auto-correct.
|
||||
Rails/ApplicationRecord:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 10
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
|
||||
Rails/Blank:
|
||||
Exclude:
|
||||
- 'app/controllers/conferences_controller.rb'
|
||||
- 'app/controllers/users/omniauth_callbacks_controller.rb'
|
||||
- 'app/models/program.rb'
|
||||
- 'app/models/user.rb'
|
||||
- 'spec/factories/event_schedule.rb'
|
||||
|
||||
# Offense count: 20
|
||||
# Configuration parameters: Include.
|
||||
# Include: db/migrate/*.rb
|
||||
Rails/CreateTableWithTimestamps:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 126
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: strict, flexible
|
||||
Rails/Date:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforceForPrefixed.
|
||||
Rails/Delegate:
|
||||
Exclude:
|
||||
- 'app/models/event.rb'
|
||||
- 'app/models/room.rb'
|
||||
- 'app/models/track.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: Whitelist.
|
||||
# Whitelist: find_by_sql
|
||||
Rails/DynamicFindBy:
|
||||
Exclude:
|
||||
- 'app/controllers/admin/events_controller.rb'
|
||||
- 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
|
||||
|
||||
# Offense count: 8
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: slashes, arguments
|
||||
Rails/FilePath:
|
||||
Exclude:
|
||||
- 'app/pdfs/ticket_pdf.rb'
|
||||
- 'config/initializers/active_record_log_subscriber.rb'
|
||||
- 'config/initializers/carrierwave.rb'
|
||||
- 'spec/features/lodgings_spec.rb'
|
||||
- 'spec/features/sponsor_spec.rb'
|
||||
- 'spec/spec_helper.rb'
|
||||
|
||||
# Offense count: 7
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/models/**/*.rb
|
||||
Rails/FindBy:
|
||||
Exclude:
|
||||
- 'app/models/event.rb'
|
||||
- 'app/models/openid.rb'
|
||||
- 'app/models/ticket_purchase.rb'
|
||||
- 'app/models/user.rb'
|
||||
|
||||
# Offense count: 6
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/models/**/*.rb
|
||||
Rails/HasAndBelongsToMany:
|
||||
Exclude:
|
||||
- 'app/models/conference.rb'
|
||||
- 'app/models/qanswer.rb'
|
||||
- 'app/models/question.rb'
|
||||
- 'app/models/registration.rb'
|
||||
- 'app/models/vchoice.rb'
|
||||
|
||||
# Offense count: 20
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/models/**/*.rb
|
||||
Rails/HasManyOrHasOneDependent:
|
||||
Exclude:
|
||||
- 'app/models/answer.rb'
|
||||
- 'app/models/event.rb'
|
||||
- 'app/models/payment.rb'
|
||||
- 'app/models/physical_ticket.rb'
|
||||
- 'app/models/question_type.rb'
|
||||
- 'app/models/registration.rb'
|
||||
- 'app/models/role.rb'
|
||||
- 'app/models/room.rb'
|
||||
- 'app/models/sponsorship_level.rb'
|
||||
- 'app/models/ticket_purchase.rb'
|
||||
- 'app/models/track.rb'
|
||||
- 'app/models/user.rb'
|
||||
- 'app/models/vday.rb'
|
||||
- 'app/models/vposition.rb'
|
||||
|
||||
# Offense count: 256
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: Include.
|
||||
# Include: spec/**/*, test/**/*
|
||||
Rails/HttpPositionalArguments:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 12
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/models/**/*.rb
|
||||
Rails/InverseOf:
|
||||
Exclude:
|
||||
- 'app/models/booth.rb'
|
||||
- 'app/models/conference.rb'
|
||||
- 'app/models/event.rb'
|
||||
- 'app/models/user.rb'
|
||||
- 'app/models/venue.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/controllers/**/*.rb
|
||||
Rails/LexicallyScopedActionFilter:
|
||||
Exclude:
|
||||
- 'app/controllers/registrations_controller.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Configuration parameters: Include.
|
||||
# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
|
||||
Rails/Output:
|
||||
Exclude:
|
||||
- 'config/environment.rb'
|
||||
|
||||
# Offense count: 4
|
||||
Rails/OutputSafety:
|
||||
Exclude:
|
||||
- 'app/helpers/events_helper.rb'
|
||||
- 'app/helpers/format_helper.rb'
|
||||
- 'app/models/commercial.rb'
|
||||
|
||||
# Offense count: 15
|
||||
# Cop supports --auto-correct.
|
||||
Rails/PluralizationGrammar:
|
||||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Cop supports --auto-correct.
|
||||
Rails/Presence:
|
||||
Exclude:
|
||||
- 'app/controllers/schedules_controller.rb'
|
||||
- 'app/helpers/application_helper.rb'
|
||||
- 'app/models/user.rb'
|
||||
|
||||
# Offense count: 23
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
|
||||
Rails/Present:
|
||||
Exclude:
|
||||
- 'app/helpers/users_helper.rb'
|
||||
- 'app/models/cfp.rb'
|
||||
- 'app/models/email_settings.rb'
|
||||
- 'app/models/event.rb'
|
||||
- 'app/models/program.rb'
|
||||
- 'app/models/venue.rb'
|
||||
- 'config/routes.rb'
|
||||
|
||||
# Offense count: 52
|
||||
# Configuration parameters: Include.
|
||||
# Include: db/migrate/*.rb
|
||||
Rails/ReversibleMigration:
|
||||
Exclude:
|
||||
- 'db/migrate/20140530082708_remove_color_defaults.rb'
|
||||
- 'db/migrate/20140605125153_update_event_states.rb'
|
||||
- 'db/migrate/20140610173021_change_person_id_to_user_id_in_registrations.rb'
|
||||
- 'db/migrate/20140611123926_change_person_id_to_user_id_in_votes.rb'
|
||||
- 'db/migrate/20140623150541_drop_person_and_event_person_tables.rb'
|
||||
- 'db/migrate/20140731165107_move_conference_contact_details_to_contact.rb'
|
||||
- 'db/migrate/20140801164901_move_conference_media_to_commercial.rb'
|
||||
- 'db/migrate/20140801170430_move_event_media_to_commercial.rb'
|
||||
- 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb'
|
||||
- 'db/migrate/20140821103643_split_ticket_price_in_price_and_currency.rb'
|
||||
- 'db/migrate/20140825093132_move_splashpage_attributes_from_conference_to_splashpage.rb'
|
||||
- 'db/migrate/20140930092923_move_sponsor_email_to_contact.rb'
|
||||
- 'db/migrate/20141117222919_drop_splash_descriptions_and_photo.rb'
|
||||
- 'db/migrate/20141130182139_drop_table_event_attachments.rb'
|
||||
|
||||
# Offense count: 8
|
||||
# Configuration parameters: Blacklist.
|
||||
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
|
||||
Rails/SkipsModelValidations:
|
||||
Exclude:
|
||||
- 'app/models/concerns/revision_count.rb'
|
||||
- 'db/migrate/20140730104658_migrate_roles_for_cancancan.rb'
|
||||
- 'db/migrate/20161229080315_add_comments_count_to_events.rb'
|
||||
- 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb'
|
||||
- 'db/migrate/20180313012253_add_timestamps_to_tickets.rb'
|
||||
- 'lib/tasks/user.rake'
|
||||
- 'spec/controllers/conferences_controller_spec.rb'
|
||||
|
||||
# Offense count: 51
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: strict, flexible
|
||||
Rails/TimeZone:
|
||||
Exclude:
|
||||
- 'app/models/comment.rb'
|
||||
- 'app/models/conference.rb'
|
||||
- 'config/environments/test.rb'
|
||||
- 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb'
|
||||
- 'db/migrate/20180313012253_add_timestamps_to_tickets.rb'
|
||||
- 'lib/tasks/dump_db.rake'
|
||||
- 'spec/controllers/admin/comments_controller_spec.rb'
|
||||
- 'spec/controllers/admin/programs_controller_spec.rb'
|
||||
- 'spec/factories/users.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 2
|
||||
Security/Open:
|
||||
Exclude:
|
||||
- 'app/pdfs/ticket_pdf.rb'
|
||||
|
||||
# Offense count: 2
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: inline, group
|
||||
Style/AccessModifierDeclarations:
|
||||
Exclude:
|
||||
- 'spec/factories/splashpages.rb'
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
|
|
@ -1046,27 +850,18 @@ Style/ColonMethodCall:
|
|||
- 'app/models/commercial.rb'
|
||||
- 'app/models/contact.rb'
|
||||
|
||||
# Offense count: 5
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
|
||||
# SupportedStyles: assign_to_condition, assign_inside_condition
|
||||
Style/ConditionalAssignment:
|
||||
Exclude:
|
||||
- 'app/helpers/format_helper.rb'
|
||||
- 'config/environments/production.rb'
|
||||
- 'config/initializers/airbrake.rb'
|
||||
- 'db/migrate/20140610165551_migrate_data_person_to_user.rb'
|
||||
- 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb'
|
||||
|
||||
# Offense count: 11
|
||||
Style/DateTime:
|
||||
Exclude:
|
||||
- 'app/models/conference.rb'
|
||||
- 'app/models/program.rb'
|
||||
- 'spec/models/conference_spec.rb'
|
||||
- 'spec/models/program_spec.rb'
|
||||
|
||||
# Offense count: 514
|
||||
# Offense count: 516
|
||||
Style/Documentation:
|
||||
Enabled: false
|
||||
|
||||
|
|
@ -1088,14 +883,13 @@ Style/EmptyLiteral:
|
|||
Exclude:
|
||||
- 'spec/models/conference_spec.rb'
|
||||
|
||||
# Offense count: 9
|
||||
# Offense count: 7
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: compact, expanded
|
||||
Style/EmptyMethod:
|
||||
Exclude:
|
||||
- 'app/controllers/admin/lodgings_controller.rb'
|
||||
- 'app/controllers/admin/registration_periods_controller.rb'
|
||||
- 'app/controllers/users_controller.rb'
|
||||
- 'db/migrate/20121223115125_create_tracks_table.rb'
|
||||
- 'db/migrate/20121223115135_create_events_table.rb'
|
||||
|
|
@ -1126,19 +920,26 @@ Style/ExpandPathArguments:
|
|||
- 'config/environment.rb'
|
||||
- 'spec/spec_helper.rb'
|
||||
|
||||
# Offense count: 44
|
||||
# Offense count: 1
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: annotated, template, unannotated
|
||||
Style/FormatStringToken:
|
||||
Exclude:
|
||||
- 'app/uploaders/picture_uploader.rb'
|
||||
|
||||
# Offense count: 49
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: when_needed, always, never
|
||||
# SupportedStyles: always, never
|
||||
Style/FrozenStringLiteralComment:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 30
|
||||
# Offense count: 29
|
||||
# Configuration parameters: MinBodyLength.
|
||||
Style/GuardClause:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 8
|
||||
# Offense count: 7
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
|
||||
# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
|
||||
|
|
@ -1149,16 +950,15 @@ Style/HashSyntax:
|
|||
- 'app/views/admin/registrations/index.xlsx.axlsx'
|
||||
- 'lib/tasks/user.rake'
|
||||
|
||||
# Offense count: 61
|
||||
# Offense count: 58
|
||||
# Cop supports --auto-correct.
|
||||
Style/IfUnlessModifier:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 8
|
||||
# Offense count: 10
|
||||
# Cop supports --auto-correct.
|
||||
Style/LineEndConcatenation:
|
||||
Exclude:
|
||||
- 'spec/features/cfp_spec.rb'
|
||||
- 'spec/features/conference_spec.rb'
|
||||
- 'spec/features/registration_periods_spec.rb'
|
||||
|
||||
|
|
@ -1192,6 +992,8 @@ Style/MultilineIfModifier:
|
|||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle.
|
||||
# SupportedStyles: literals, strict
|
||||
Style/MutableConstant:
|
||||
Exclude:
|
||||
- 'app/models/event_user.rb'
|
||||
|
|
@ -1213,7 +1015,7 @@ Style/NestedParenthesizedCalls:
|
|||
Style/Next:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 121
|
||||
# Offense count: 120
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedOctalStyle.
|
||||
# SupportedOctalStyles: zero_with_o, zero_only
|
||||
|
|
@ -1234,9 +1036,9 @@ Style/NumericLiteralPrefix:
|
|||
Style/NumericLiterals:
|
||||
MinDigits: 15
|
||||
|
||||
# Offense count: 41
|
||||
# Offense count: 36
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AutoCorrect, EnforcedStyle.
|
||||
# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
|
||||
# SupportedStyles: predicate, comparison
|
||||
Style/NumericPredicate:
|
||||
Exclude:
|
||||
|
|
@ -1274,7 +1076,7 @@ Style/ParenthesesAroundCondition:
|
|||
- 'app/controllers/application_controller.rb'
|
||||
- 'app/helpers/format_helper.rb'
|
||||
|
||||
# Offense count: 28
|
||||
# Offense count: 22
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: PreferredDelimiters.
|
||||
Style/PercentLiteralDelimiters:
|
||||
|
|
@ -1307,15 +1109,15 @@ Style/RedundantParentheses:
|
|||
Exclude:
|
||||
- 'app/controllers/admin/base_controller.rb'
|
||||
|
||||
# Offense count: 3
|
||||
# Offense count: 4
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
|
||||
# SupportedStyles: slashes, percent_r, mixed
|
||||
Style/RegexpLiteral:
|
||||
Exclude:
|
||||
- 'Guardfile'
|
||||
- 'config/initializers/airbrake.rb'
|
||||
- 'app/uploaders/picture_uploader.rb'
|
||||
- 'config/initializers/airbrake.rb'
|
||||
|
||||
# Offense count: 2
|
||||
# Cop supports --auto-correct.
|
||||
|
|
@ -1342,21 +1144,18 @@ Style/SingleLineMethods:
|
|||
Exclude:
|
||||
- 'Guardfile'
|
||||
|
||||
# Offense count: 672
|
||||
# Offense count: 611
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
|
||||
# SupportedStyles: single_quotes, double_quotes
|
||||
Style/StringLiterals:
|
||||
Exclude:
|
||||
- 'Gemfile'
|
||||
- 'Vagrantfile'
|
||||
- 'bin/rspec'
|
||||
- 'bin/spring'
|
||||
- 'config/deploy.rb'
|
||||
- 'config/environments/production.rb'
|
||||
- 'config/initializers/devise.rb'
|
||||
- 'config/puma.rb'
|
||||
- 'config/routes.rb'
|
||||
- 'db/schema.rb'
|
||||
- 'lib/tasks/dump_db.rake'
|
||||
- 'lib/tasks/events_registrations.rake'
|
||||
|
|
@ -1374,19 +1173,13 @@ Style/StringLiteralsInInterpolation:
|
|||
- 'app/views/admin/events/_confirmed_events.xlsx.axlsx'
|
||||
- 'lib/tasks/dump_db.rake'
|
||||
|
||||
# Offense count: 109
|
||||
# Offense count: 110
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: EnforcedStyle, MinSize.
|
||||
# SupportedStyles: percent, brackets
|
||||
Style/SymbolArray:
|
||||
Enabled: false
|
||||
|
||||
# Offense count: 1
|
||||
# Cop supports --auto-correct.
|
||||
Style/SymbolLiteral:
|
||||
Exclude:
|
||||
- 'config/deploy.rb'
|
||||
|
||||
# Offense count: 10
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: IgnoredMethods.
|
||||
|
|
@ -1439,7 +1232,7 @@ Style/UnneededCondition:
|
|||
- 'app/helpers/versions_helper.rb'
|
||||
- 'app/models/ticket.rb'
|
||||
|
||||
# Offense count: 8
|
||||
# Offense count: 9
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: WordRegex.
|
||||
# SupportedStyles: percent, brackets
|
||||
|
|
@ -1447,8 +1240,9 @@ Style/WordArray:
|
|||
EnforcedStyle: percent
|
||||
MinSize: 8
|
||||
|
||||
# Offense count: 3041
|
||||
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
|
||||
# Offense count: 2915
|
||||
# Cop supports --auto-correct.
|
||||
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
|
||||
# URISchemes: http, https
|
||||
Metrics/LineLength:
|
||||
Max: 619
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue