From 0d01ed08b0351ef7839c7e8ef53d03ac24ed7c72 Mon Sep 17 00:00:00 2001
From: divyanshumehta <divyanshumehta@outlook.com>
Date: Mon, 29 May 2017 09:32:57 +0530
Subject: [PATCH 1/2] Added Style/SpaceInsideBrackets Rubocop cop

---
 .rubocop.yml             | 4 ++++
 .rubocop_todo.yml        | 7 -------
 app/models/conference.rb | 2 +-
 app/models/user.rb       | 4 ++--
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index de234a2a..9f7f0d00 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -88,6 +88,10 @@ Style/RedundantSelf:
 Style/SpaceAroundOperators:
   Enabled: true
 
+# Checks for spaces inside square brackets.
+Style/SpaceInsideBrackets:
+  Enabled: true
+
 # Use single quotes unless there's string interpolation
 Style/StringLiterals:
   Enabled: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a7ea415b..37164318 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -811,13 +811,6 @@ Style/SpaceInsideBlockBraces:
     - 'spec/models/ability_spec.rb'
     - 'spec/models/user_spec.rb'
 
-# Offense count: 5
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Exclude:
-    - 'app/models/conference.rb'
-    - 'app/models/user.rb'
-
 # Offense count: 25
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.
diff --git a/app/models/conference.rb b/app/models/conference.rb
index 1c4ccc73..79b38be2 100644
--- a/app/models/conference.rb
+++ b/app/models/conference.rb
@@ -803,7 +803,7 @@ class Conference < ActiveRecord::Base
         hash[key] = 0
       end
     end
-    Hash[ hash.sort ]
+    Hash[hash.sort]
   end
 
   ##
diff --git a/app/models/user.rb b/app/models/user.rb
index a63d721e..4be77fe8 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -26,11 +26,11 @@ class User < ActiveRecord::Base
   devise_modules = []
 
   if ENV['OSEM_ICHAIN_ENABLED'] == 'true'
-    devise_modules += [ :ichain_authenticatable, :ichain_registerable, :omniauthable, omniauth_providers: [] ]
+    devise_modules += [:ichain_authenticatable, :ichain_registerable, :omniauthable, omniauth_providers: []]
   else
     devise_modules += [:database_authenticatable, :registerable,
                        :recoverable, :rememberable, :trackable, :validatable, :confirmable,
-                       :omniauthable, omniauth_providers: [:suse, :google, :facebook, :github] ]
+                       :omniauthable, omniauth_providers: [:suse, :google, :facebook, :github]]
   end
 
   devise(*devise_modules)

From 1223fef87c0467ce58fab121832852e77217f0eb Mon Sep 17 00:00:00 2001
From: divyanshumehta <divyanshumehta@outlook.com>
Date: Mon, 29 May 2017 15:02:14 +0530
Subject: [PATCH 2/2] Use of rubocop compliant unescaping methods in
 application_helper.rb

---
 app/helpers/application_helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index b3081f9b..e0b3b85b 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -147,7 +147,7 @@ module ApplicationHelper
   end
 
   def speaker_links(event)
-    event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }.join(', ').html_safe
+    safe_join(event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }, ',')
   end
 
   def speaker_selector_input(form)