From 5aa85f233efc6e97cbf76ee2aaf8cc8a94a78d82 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Sat, 16 Feb 2019 00:31:15 +0100 Subject: [PATCH] Can't cache javascript that is supposed to run MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From the CaptureHelper docu¹ ``` WARNING: content_for is ignored in caches. So you shouldn't use it for elements that will be fragment cached. ``` ¹ https://api.rubyonrails.org/classes/ActionView/Helpers/CaptureHelper.html#method-i-content_for --- app/views/conferences/show.html.haml | 35 ++++++++++++++-------------- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/app/views/conferences/show.html.haml b/app/views/conferences/show.html.haml index 65db8bbc..e8f64db3 100644 --- a/app/views/conferences/show.html.haml +++ b/app/views/conferences/show.html.haml @@ -64,22 +64,21 @@ = render 'social_media', contact: @conference.contact = render 'footer' -- cache [@conference.color, '#splash#inlinejs'] do - - content_for :script_head do - :javascript - var triangle_tcs = tinycolor("#{h(@conference.color)}").monochromatic(); - var triangle_colors = triangle_tcs.map(function(t) { - return t.toHexString(); - }); - $(function () { - $(document).ready(function() { - var triangle_width = document.body.clientWidth; - var triangle_height = ($( "#banner" ).height() + 200 ); - var pattern = Trianglify({ width: triangle_width, - height: triangle_height, - cell_size: 100, - x_colors: triangle_colors - }); - $('#banner').css('background-image', 'url("' + pattern.png() + '")'); - }); +- content_for :script_head do + :javascript + var triangle_tcs = tinycolor("#{h(@conference.color)}").monochromatic(); + var triangle_colors = triangle_tcs.map(function(t) { + return t.toHexString(); + }); + $(function () { + $(document).ready(function() { + var triangle_width = document.body.clientWidth; + var triangle_height = ($( "#banner" ).height() + 200 ); + var pattern = Trianglify({ width: triangle_width, + height: triangle_height, + cell_size: 100, + x_colors: triangle_colors + }); + $('#banner').css('background-image', 'url("' + pattern.png() + '")'); }); + });