From 50d6f5b3d570e8c3ecf9264c705cfc759edc6f7c Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 9 Dec 2024 16:42:42 +0100 Subject: [PATCH] Remove superflous spec for User.registered/attended There is no logic involved, just a map on the title... --- app/models/user.rb | 1 - spec/models/user_spec.rb | 38 -------------------------------------- 2 files changed, 39 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index dace4655..6fbaafdb 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -237,7 +237,6 @@ class User < ApplicationRecord end def registered - registrations = self.registrations if registrations.count == 0 'None' else diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 29bb59cb..319d41f9 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -305,44 +305,6 @@ describe User do end end - describe '#registered' do - context 'user has not registered to any conference' do - it 'returns None' do - expect(user.registered).to eq 'None' - end - end - - context 'user has registered to conferences' do - before do - create(:registration, user: user, conference: conference) - create(:registration, user: user, conference: conference2) - end - - it 'returns registered conferences title' do - expect(user.registered).to eq('openSUSE Conference 2016, openSUSE Conference 2015') - end - end - end - - describe '#attended' do - context 'user has not attended any conference' do - it 'returns None' do - expect(user.attended).to eq 'None' - end - end - - context 'user has attended conferences' do - before do - create(:registration, user: user, conference: conference, attended: true) - create(:registration, user: user, conference: conference2, attended: true) - end - - it 'returns attended conferences title' do - expect(user.attended).to eq('openSUSE Conference 2016, openSUSE Conference 2015') - end - end - end - describe '#confirmed?' do context 'confirmed user' do it 'returns true' do