Merge pull request #2818 from hennevogel/refactor/rspec-pending

rspec exits with 1 for pending specs somehow...

spec/datatables/user_datatable_spec.rb

@@ -95,22 +95,22 @@ describe UserDatatable do
     let(:output) { subject.as_json }
 
     it 'recordsTotal' do
-      pending('This fails since Ruby 2.5.8')
+      skip('This fails since Ruby 2.5.8')
       expect(output[:recordsTotal]).to eq(1)
     end
 
     it 'recordsFiltered' do
-      pending('This fails since Ruby 2.5.8')
+      skip('This fails since Ruby 2.5.8')
       expect(output[:recordsFiltered]).to eq(1)
     end
 
     it 'data length' do
-      pending('This fails since Ruby 2.5.8')
+      skip('This fails since Ruby 2.5.8')
       expect(output[:data].length).to eq(1)
     end
 
     it 'has expected data columns' do
-      pending('This fails since Ruby 2.5.8')
+      skip('This fails since Ruby 2.5.8')
       expect(output[:data].first.keys).to eq(data_cols)
     end
 
@@ -118,32 +118,32 @@ describe UserDatatable do
       let(:user_data) { output[:data].first }
 
       it 'id' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(user_data[:id].to_i).to eq(user.id)
       end
 
       it 'name' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(user_data[:name]).to eq(user.name)
       end
 
       it 'email' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(user_data[:email]).to eq(user.email)
       end
 
       it 'confirmed_at' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(Date.parse(user_data[:confirmed_at])).to eq(user.confirmed_at.to_date)
       end
 
       it 'attended' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(user_data[:attended].to_i).to eq(user.attended_count)
       end
 
       it 'roles' do
-        pending('This fails since Ruby 2.5.8')
+        skip('This fails since Ruby 2.5.8')
         expect(user_data[:roles]).to eq('None')
       end
     end