From 4824537aebfc88ace86bf46b7f00c0100a27fbac Mon Sep 17 00:00:00 2001 From: divyanshumehta Date: Sun, 21 May 2017 21:02:30 +0530 Subject: [PATCH] Added Rails/Delegate Rubucop Cop --- .rubocop.yml | 4 ++++ .rubocop_todo.yml | 6 ------ app/serializers/speaker_serializer.rb | 4 +--- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 9410af03..c333e43a 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -188,6 +188,10 @@ Rails: Rails/Validation: Enabled: true +# Looks for delegations, that could have been created automatically with delegate method +Rails/Delegate: + Enabled: true + #################### Performance ############################### # Identifies places where gsub can be replaced by tr or delete. diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 11fedc97..4356de97 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -124,12 +124,6 @@ Rails/Blank: Rails/Date: Enabled: false -# Offense count: 1 -# Cop supports --auto-correct. -Rails/Delegate: - Exclude: - - 'app/serializers/speaker_serializer.rb' - # Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: Whitelist. diff --git a/app/serializers/speaker_serializer.rb b/app/serializers/speaker_serializer.rb index c017fb31..4a455a61 100644 --- a/app/serializers/speaker_serializer.rb +++ b/app/serializers/speaker_serializer.rb @@ -3,7 +3,5 @@ class SpeakerSerializer < ActiveModel::Serializer attributes :name, :affiliation, :biography - def name - object.name - end + delegate :name, to: :object end