gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable Style/RedundantSelf Rubocop cop

Browse source 
This cop checks for redundant uses of self. It supports autocorrection, so all the offenses where automatically solved.

Closes #1373
This commit is contained in:
Chaitanya 2017-03-28 13:27:52 +05:30
parent 444ceb8960
commit 4427f43bdf
11 changed files with 48 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/models/user.rb
View file

@ -72,7 +72,7 @@ class User < ActiveRecord::Base
# * +true+ if the user attended the event
# * +false+ if the user did not attend the event
def attended_event? event
event_registration = event.events_registrations.find_by(registration: self.registrations)
event_registration = event.events_registrations.find_by(registration: registrations)
return false unless event_registration.present?
event_registration.attended
@ -91,7 +91,7 @@ class User < ActiveRecord::Base
end
def subscribed? conference
self.subscriptions.find_by(conference_id: conference.id).present?
subscriptions.find_by(conference_id: conference.id).present?
end
def supports? conference
@ -206,8 +206,8 @@ class User < ActiveRecord::Base
# Check if biography has an allowed number of words. Used as validation.
#
def biography_limit
if self.biography.present?
errors.add(:biography, 'is limited to 150 words.') if self.biography.split.length > 150
if biography.present?
errors.add(:biography, 'is limited to 150 words.') if biography.split.length > 150
end
end
end