gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Get rid of build_email

Browse source 
It's always easy to add another layer of indirection...
This commit is contained in:
Henne Vogelsang 2016-04-21 16:36:53 +02:00
parent a698ce44fe
commit 37e0b5f5b8
1 changed files with 23 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

52
app/mailers/mailbot.rb
View file

@ -1,38 +1,41 @@
class Mailbot < ActionMailer::Base class Mailbot < ActionMailer::Base
default from: 'no-reply@example.com' default from: 'no-reply@example.com'
def registration_mail(conference, person) def registration_mail(conference, user)
build_email(conference, mail(to: user.email,
person.email, from: conference.contact.email,
conference.email_settings.registration_subject, subject: conference.email_settings.registration_subject,
conference.email_settings.generate_email_on_conf_updates(conference, person, conference.email_settings.registration_body)) body: conference.email_settings.generate_email_on_conf_updates(conference,
user,
conference.email_settings.registration_body))
end end
def acceptance_mail(event) def acceptance_mail(event)
conference = event.program.conference conference = event.program.conference
person = event.submitter
build_email(conference, mail(to: event.submitter.email,
person.email, from: conference.contact.email,
conference.email_settings.accepted_subject, subject: conference.email_settings.accepted_subject,
conference.email_settings.generate_event_mail(event, conference.email_settings.accepted_body)) body: conference.email_settings.generate_event_mail(event, conference.email_settings.accepted_body))
end end
def rejection_mail(event) def rejection_mail(event)
conference = event.program.conference conference = event.program.conference
person = event.submitter
build_email(conference, mail(to: event.submitter.email,
person.email, from: conference.contact.email,
conference.email_settings.rejected_subject, subject: conference.email_settings.rejected_subject,
conference.email_settings.generate_event_mail(event, conference.email_settings.rejected_body)) body: conference.email_settings.generate_event_mail(event, conference.email_settings.rejected_body))
end end
def confirm_reminder_mail(event) def confirm_reminder_mail(event)
conference = event.program.conference conference = event.program.conference
person = event.submitter
build_email(conference, mail(to: event.submitter.email,
person.email, from: conference.contact.email,
conference.email_settings.confirmed_without_registration_subject, subject: conference.email_settings.confirmed_without_registration_subject,
conference.email_settings.generate_event_mail(event, conference.email_settings.confirmed_without_registration_body)) body: conference.email_settings.generate_event_mail(event,
conference.email_settings.confirmed_without_registration_body))
end end
def conference_date_update_mail(conference, user) def conference_date_update_mail(conference, user)
@ -95,13 +98,4 @@ class Mailbot < ActionMailer::Base
subject: "New comment has been posted for #{@event.title}") subject: "New comment has been posted for #{@event.title}")
end end
end end
def build_email(conference, to, subject, body)
logger.debug "Sending mail about #{subject} to #{to}"
mail(to: to,
from: conference.contact.email,
reply_to: conference.contact.email,
subject: subject,
body: body)
end
end end