gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Create a factory for organizer

Browse source 
Refactor organizer user creation in tests

Fixes https://github.com/openSUSE/osem/issues/2398
This commit is contained in:
cyrille 2019-03-13 10:31:42 +01:00
parent 0197ed3c46
commit 35ec178beb
31 changed files with 48 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/models/conference_spec.rb
View file

@ -285,8 +285,7 @@ describe Conference do
describe '#get_top_submitter' do
let!(:conference) { create(:conference) }
let!(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let!(:organizer) { create(:user, role_ids: [organizer_role.id]) }
let!(:organizer) { create(:organizer, resource: conference) }
it 'calculates correct hash with top submitters' do
event = create(:event, program: subject.program)
@ -866,8 +865,7 @@ describe Conference do
describe 'self#event_distribution' do
let!(:conference) { create(:conference) }
let!(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let!(:organizer) { create(:user, role_ids: [organizer_role.id]) }
let!(:organizer) { create(:organizer, resource: conference) }
it 'self#user_distribution calculates correct values with user' do
result = {}
@ -1386,9 +1384,7 @@ describe Conference do
# It is necessary to use bang version of let to build roles before user
let!(:conference) { create(:conference) }
let!(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let!(:organizer) { create(:user, role_ids: [organizer_role.id]) }
let!(:organizer) { create(:organizer, resource: conference) }
let(:user) { create(:user) }
context 'user not registered' do

2
spec/models/role_spec.rb
View file

@ -6,7 +6,7 @@ describe Role do
let(:conference) { create(:conference) }
let!(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let!(:cfp_role) { Role.find_by(name: 'cfp', resource: conference) }
let!(:organizer) { create(:user, role_ids: organizer_role.id) }
let!(:organizer) { create(:organizer, resource: conference) }
let(:user) { create(:user) }
it 'get_users' do

5
spec/models/user_spec.rb
View file

@ -10,7 +10,7 @@ describe User do
let(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let(:cfp_role) { Role.find_by(name: 'cfp', resource: conference) }
let(:volunteers_coordinator_role) { Role.find_by(name: 'volunteers_coordinator', resource: conference) }
let(:organizer) { create(:user, role_ids: [organizer_role.id]) }
let(:organizer) { create(:organizer, resource: conference) }
let(:user) { create(:user) }
let(:user_disabled) { create(:user, :disabled) }
@ -417,8 +417,7 @@ describe User do
describe '#has_cached_role?' do
describe 'when user has a role' do
it 'returns true when the user has the role' do
user = create(:user, role_ids: organizer_role.id)
expect(user.has_cached_role?('organizer', conference)).to be true
expect(organizer.has_cached_role?('organizer', conference)).to be true
end
it 'returns false when the user does not have the role' do