gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Update rubocop TODO

Browse source
This commit is contained in:
Henne Vogelsang 2024-06-07 16:34:45 +02:00
parent 494af47af2
commit 350153a5f0
No known key found for this signature in database
GPG key ID: 97DDB66BDAF8D4D6
1 changed files with 112 additions and 101 deletions
Download patch file Download diff file Expand all files Collapse all files

213
.rubocop_todo.yml
View file

@ -1,12 +1,12 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config` # `rubocop --auto-gen-config`
# on 2024-06-06 15:22:39 UTC using RuboCop version 1.63.5. # on 2024-06-07 15:38:52 UTC using RuboCop version 1.64.1.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again. # versions of RuboCop, may require this file to be generated again.
# Offense count: 3 # Offense count: 4
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
# Include: **/*.gemfile, **/Gemfile, **/gems.rb # Include: **/*.gemfile, **/Gemfile, **/gems.rb
@ -14,13 +14,13 @@ Bundler/OrderedGems:
Exclude: Exclude:
- 'Gemfile' - 'Gemfile'
# Offense count: 161 # Offense count: 151
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: link_or_button, strict # SupportedStyles: link_or_button, strict
Capybara/ClickLinkOrButtonStyle: Capybara/ClickLinkOrButtonStyle:
Enabled: false Enabled: false
# Offense count: 350 # Offense count: 280
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Capybara/CurrentPathExpectation: Capybara/CurrentPathExpectation:
Exclude: Exclude:
@ -28,7 +28,6 @@ Capybara/CurrentPathExpectation:
- 'spec/features/cfp_ability_spec.rb' - 'spec/features/cfp_ability_spec.rb'
- 'spec/features/conference_registration_spec.rb' - 'spec/features/conference_registration_spec.rb'
- 'spec/features/info_desk_ability_spec.rb' - 'spec/features/info_desk_ability_spec.rb'
- 'spec/features/organization_admin_ability_spec.rb'
- 'spec/features/organizer_ability_spec.rb' - 'spec/features/organizer_ability_spec.rb'
- 'spec/features/proposals_spec.rb' - 'spec/features/proposals_spec.rb'
- 'spec/features/registration_periods_spec.rb' - 'spec/features/registration_periods_spec.rb'
@ -37,29 +36,20 @@ Capybara/CurrentPathExpectation:
- 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/track_organizer_ability_spec.rb'
- 'spec/features/user_ability_spec.rb' - 'spec/features/user_ability_spec.rb'
# Offense count: 3 # Offense count: 13
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: have_no, not_to
Capybara/NegationMatcher:
Exclude:
- 'spec/features/code_of_conduct_spec.rb'
# Offense count: 14
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: DefaultSelector. # Configuration parameters: DefaultSelector.
Capybara/RSpec/HaveSelector: Capybara/RSpec/HaveSelector:
Exclude: Exclude:
- 'spec/features/cfp_ability_spec.rb' - 'spec/features/cfp_ability_spec.rb'
- 'spec/features/info_desk_ability_spec.rb' - 'spec/features/info_desk_ability_spec.rb'
- 'spec/features/organization_admin_ability_spec.rb'
- 'spec/features/organizer_ability_spec.rb' - 'spec/features/organizer_ability_spec.rb'
- 'spec/features/proposals_spec.rb' - 'spec/features/proposals_spec.rb'
- 'spec/features/sponsor_spec.rb' - 'spec/features/sponsor_spec.rb'
- 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/track_organizer_ability_spec.rb'
- 'spec/features/voting_spec.rb' - 'spec/features/voting_spec.rb'
# Offense count: 82 # Offense count: 78
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Capybara/SpecificFinders: Capybara/SpecificFinders:
Enabled: false Enabled: false
@ -81,7 +71,7 @@ FactoryBot/AssociationStyle:
- 'spec/factories/surveys.rb' - 'spec/factories/surveys.rb'
- 'spec/factories/tracks.rb' - 'spec/factories/tracks.rb'
# Offense count: 12 # Offense count: 11
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Include, EnforcedStyle, ExplicitOnly. # Configuration parameters: Include, EnforcedStyle, ExplicitOnly.
# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb # Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
@ -168,7 +158,7 @@ Layout/ExtraSpacing:
- 'db/migrate/20140719160903_create_delayed_jobs.rb' - 'db/migrate/20140719160903_create_delayed_jobs.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 43 # Offense count: 42
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
@ -242,7 +232,7 @@ Layout/LineContinuationSpacing:
- 'app/controllers/conference_registrations_controller.rb' - 'app/controllers/conference_registrations_controller.rb'
- 'app/models/cfp.rb' - 'app/models/cfp.rb'
# Offense count: 32 # Offense count: 31
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented # SupportedStyles: aligned, indented
@ -273,14 +263,14 @@ Layout/MultilineHashBraceLayout:
- 'config/routes.rb' - 'config/routes.rb'
- 'spec/models/event_spec.rb' - 'spec/models/event_spec.rb'
# Offense count: 33 # Offense count: 32
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: symmetrical, new_line, same_line # SupportedStyles: symmetrical, new_line, same_line
Layout/MultilineMethodCallBraceLayout: Layout/MultilineMethodCallBraceLayout:
Enabled: false Enabled: false
# Offense count: 47 # Offense count: 38
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver # SupportedStyles: aligned, indented, indented_relative_to_receiver
@ -326,12 +316,11 @@ Layout/SpaceAroundKeyword:
Exclude: Exclude:
- 'config/initializers/feature.rb' - 'config/initializers/feature.rb'
# Offense count: 4 # Offense count: 3
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Layout/SpaceAroundMethodCallOperator: Layout/SpaceAroundMethodCallOperator:
Exclude: Exclude:
- 'spec/features/cfp_ability_spec.rb' - 'spec/features/cfp_ability_spec.rb'
- 'spec/features/organization_admin_ability_spec.rb'
- 'spec/features/organizer_ability_spec.rb' - 'spec/features/organizer_ability_spec.rb'
- 'spec/models/program_spec.rb' - 'spec/models/program_spec.rb'
@ -345,7 +334,7 @@ Layout/SpaceAroundOperators:
- 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - 'app/views/admin/events/_all_with_comments.xlsx.axlsx'
- 'lib/tasks/data.rake' - 'lib/tasks/data.rake'
# Offense count: 139 # Offense count: 138
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
@ -382,7 +371,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
- 'config/initializers/devise.rb' - 'config/initializers/devise.rb'
- 'config/routes.rb' - 'config/routes.rb'
# Offense count: 44 # Offense count: 42
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
@ -447,12 +436,11 @@ Layout/TrailingEmptyLines:
- 'lib/tasks/event_attatchments.rake' - 'lib/tasks/event_attatchments.rake'
- 'lib/tasks/roles.rake' - 'lib/tasks/roles.rake'
# Offense count: 13 # Offense count: 11
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowedMethods, AllowedPatterns. # Configuration parameters: AllowedMethods, AllowedPatterns.
Lint/AmbiguousBlockAssociation: Lint/AmbiguousBlockAssociation:
Exclude: Exclude:
- 'spec/controllers/admin/conferences_controller_spec.rb'
- 'spec/controllers/admin/event_schedules_controller_spec.rb' - 'spec/controllers/admin/event_schedules_controller_spec.rb'
- 'spec/controllers/admin/registration_periods_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb'
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
@ -511,11 +499,12 @@ Lint/UnusedBlockArgument:
Exclude: Exclude:
- 'lib/tasks/user.rake' - 'lib/tasks/user.rake'
# Offense count: 1 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. # Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
Lint/UnusedMethodArgument: Lint/UnusedMethodArgument:
Exclude: Exclude:
- 'app/helpers/application_helper.rb'
- 'config/initializers/fuckups.rb' - 'config/initializers/fuckups.rb'
# Offense count: 2 # Offense count: 2
@ -525,16 +514,16 @@ Lint/UriRegexp:
- 'app/models/commercial.rb' - 'app/models/commercial.rb'
- 'app/models/contact.rb' - 'app/models/contact.rb'
# Offense count: 127 # Offense count: 125
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize: Metrics/AbcSize:
Max: 72 Max: 70
# Offense count: 28 # Offense count: 28
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
# AllowedMethods: refine # AllowedMethods: refine
Metrics/BlockLength: Metrics/BlockLength:
Max: 211 Max: 202
# Offense count: 1 # Offense count: 1
# Configuration parameters: CountBlocks. # Configuration parameters: CountBlocks.
@ -544,9 +533,9 @@ Metrics/BlockNesting:
# Offense count: 14 # Offense count: 14
# Configuration parameters: CountComments, CountAsOne. # Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength: Metrics/ClassLength:
Max: 652 Max: 649
# Offense count: 26 # Offense count: 25
# Configuration parameters: AllowedMethods, AllowedPatterns. # Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 16 Max: 16
@ -561,7 +550,7 @@ Metrics/MethodLength:
Metrics/ModuleLength: Metrics/ModuleLength:
Max: 174 Max: 174
# Offense count: 23 # Offense count: 21
# Configuration parameters: AllowedMethods, AllowedPatterns. # Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Max: 19 Max: 19
@ -661,13 +650,13 @@ RSpec/BeEmpty:
- 'spec/controllers/conference_registration_controller_spec.rb' - 'spec/controllers/conference_registration_controller_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 161 # Offense count: 143
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnabledMethods. # Configuration parameters: EnabledMethods.
RSpec/Capybara/FeatureMethods: RSpec/Capybara/FeatureMethods:
Enabled: false Enabled: false
# Offense count: 318 # Offense count: 302
# Configuration parameters: Prefixes, AllowedPatterns. # Configuration parameters: Prefixes, AllowedPatterns.
# Prefixes: when, with, without # Prefixes: when, with, without
RSpec/ContextWording: RSpec/ContextWording:
@ -713,29 +702,26 @@ RSpec/EmptyLineAfterExampleGroup:
Exclude: Exclude:
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
# Offense count: 11 # Offense count: 10
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
RSpec/EmptyLineAfterFinalLet: RSpec/EmptyLineAfterFinalLet:
Exclude: Exclude:
- 'spec/controllers/admin/event_schedules_controller_spec.rb' - 'spec/controllers/admin/event_schedules_controller_spec.rb'
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
- 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb'
- 'spec/features/conference_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 16 # Offense count: 12
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowConsecutiveOneLiners. # Configuration parameters: AllowConsecutiveOneLiners.
RSpec/EmptyLineAfterHook: RSpec/EmptyLineAfterHook:
Exclude: Exclude:
- 'spec/controllers/admin/booths_controller_spec.rb' - 'spec/controllers/admin/booths_controller_spec.rb'
- 'spec/controllers/admin/comments_controller_spec.rb' - 'spec/controllers/admin/comments_controller_spec.rb'
- 'spec/controllers/admin/organizations_controller_spec.rb'
- 'spec/controllers/admin/ticket_scannings_controller_spec.rb' - 'spec/controllers/admin/ticket_scannings_controller_spec.rb'
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
- 'spec/features/organization_spec.rb'
- 'spec/features/roles_spec.rb' - 'spec/features/roles_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
@ -754,18 +740,17 @@ RSpec/EmptyLineAfterSubject:
- 'spec/models/survey_spec.rb' - 'spec/models/survey_spec.rb'
- 'spec/models/track_spec.rb' - 'spec/models/track_spec.rb'
# Offense count: 215 # Offense count: 202
# Configuration parameters: CountAsOne. # Configuration parameters: CountAsOne.
RSpec/ExampleLength: RSpec/ExampleLength:
Max: 187 Max: 181
# Offense count: 15 # Offense count: 13
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. # Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
# DisallowedExamples: works # DisallowedExamples: works
RSpec/ExampleWording: RSpec/ExampleWording:
Exclude: Exclude:
- 'spec/controllers/admin/organizations_controller_spec.rb'
- 'spec/controllers/admin/registration_periods_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb'
- 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb'
- 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb'
@ -775,16 +760,14 @@ RSpec/ExampleWording:
- 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_purchase_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 37 # Offense count: 32
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block # SupportedStyles: method_call, block
RSpec/ExpectChange: RSpec/ExpectChange:
Exclude: Exclude:
- 'spec/controllers/admin/booths_controller_spec.rb' - 'spec/controllers/admin/booths_controller_spec.rb'
- 'spec/controllers/admin/conferences_controller_spec.rb'
- 'spec/controllers/admin/event_schedules_controller_spec.rb' - 'spec/controllers/admin/event_schedules_controller_spec.rb'
- 'spec/controllers/admin/organizations_controller_spec.rb'
- 'spec/controllers/admin/registration_periods_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb'
- 'spec/controllers/admin/schedules_controller_spec.rb' - 'spec/controllers/admin/schedules_controller_spec.rb'
- 'spec/controllers/admin/ticket_scannings_controller_spec.rb' - 'spec/controllers/admin/ticket_scannings_controller_spec.rb'
@ -811,7 +794,7 @@ RSpec/FilePath:
- 'spec/models/comment_spec.rb' - 'spec/models/comment_spec.rb'
- 'spec/models/openid.rb' - 'spec/models/openid.rb'
# Offense count: 172 # Offense count: 166
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example # SupportedStyles: implicit, each, example
@ -823,7 +806,7 @@ RSpec/IdenticalEqualityAssertion:
Exclude: Exclude:
- 'spec/controllers/admin/conferences_controller_spec.rb' - 'spec/controllers/admin/conferences_controller_spec.rb'
# Offense count: 140 # Offense count: 137
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: is_expected, should # SupportedStyles: is_expected, should
@ -834,7 +817,6 @@ RSpec/ImplicitExpect:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/event_schedule_spec.rb' - 'spec/models/event_schedule_spec.rb'
- 'spec/models/event_type_spec.rb' - 'spec/models/event_type_spec.rb'
- 'spec/models/organization_spec.rb'
- 'spec/models/registration_period_spec.rb' - 'spec/models/registration_period_spec.rb'
- 'spec/models/room_spec.rb' - 'spec/models/room_spec.rb'
- 'spec/models/schedule_spec.rb' - 'spec/models/schedule_spec.rb'
@ -844,7 +826,7 @@ RSpec/ImplicitExpect:
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
- 'spec/models/user_spec.rb' - 'spec/models/user_spec.rb'
# Offense count: 39 # Offense count: 38
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit # SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit
@ -854,7 +836,6 @@ RSpec/ImplicitSubject:
- 'spec/models/booth_spec.rb' - 'spec/models/booth_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/event_type_spec.rb' - 'spec/models/event_type_spec.rb'
- 'spec/models/organization_spec.rb'
- 'spec/models/registration_period_spec.rb' - 'spec/models/registration_period_spec.rb'
- 'spec/models/sponsor_spec.rb' - 'spec/models/sponsor_spec.rb'
- 'spec/models/sponsorship_level_spec.rb' - 'spec/models/sponsorship_level_spec.rb'
@ -901,11 +882,11 @@ RSpec/LeadingSubject:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 61 # Offense count: 56
RSpec/LetSetup: RSpec/LetSetup:
Enabled: false Enabled: false
# Offense count: 4 # Offense count: 3
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
RSpec/MatchArray: RSpec/MatchArray:
Exclude: Exclude:
@ -919,7 +900,7 @@ RSpec/MatchArray:
RSpec/MessageSpies: RSpec/MessageSpies:
EnforcedStyle: receive EnforcedStyle: receive
# Offense count: 244 # Offense count: 225
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: hash, symbol # SupportedStyles: hash, symbol
@ -931,14 +912,14 @@ RSpec/MultipleDescribes:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 270 # Offense count: 251
RSpec/MultipleExpectations: RSpec/MultipleExpectations:
Max: 97 Max: 94
# Offense count: 249 # Offense count: 218
# Configuration parameters: AllowSubject. # Configuration parameters: AllowSubject.
RSpec/MultipleMemoizedHelpers: RSpec/MultipleMemoizedHelpers:
Max: 32 Max: 31
# Offense count: 396 # Offense count: 396
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
@ -950,7 +931,7 @@ RSpec/NamedSubject:
- 'spec/models/room_spec.rb' - 'spec/models/room_spec.rb'
- 'spec/models/track_spec.rb' - 'spec/models/track_spec.rb'
# Offense count: 208 # Offense count: 202
# Configuration parameters: AllowedGroups. # Configuration parameters: AllowedGroups.
RSpec/NestedGroups: RSpec/NestedGroups:
Max: 7 Max: 7
@ -964,12 +945,27 @@ RSpec/NoExpectationExample:
- 'spec/controllers/admin/registration_periods_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb'
- 'spec/features/voting_spec.rb' - 'spec/features/voting_spec.rb'
# Offense count: 83 # Offense count: 78
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: not_to, to_not # SupportedStyles: not_to, to_not
RSpec/NotToNot: RSpec/NotToNot:
Enabled: false Exclude:
- 'spec/controllers/admin/booths_controller_spec.rb'
- 'spec/controllers/admin/event_schedules_controller_spec.rb'
- 'spec/controllers/admin/registration_periods_controller_spec.rb'
- 'spec/controllers/admin/ticket_scannings_controller_spec.rb'
- 'spec/controllers/booths_controller_spec.rb'
- 'spec/features/cfp_ability_spec.rb'
- 'spec/features/info_desk_ability_spec.rb'
- 'spec/features/organizer_ability_spec.rb'
- 'spec/features/sponsor_spec.rb'
- 'spec/features/track_organizer_ability_spec.rb'
- 'spec/features/tracks_spec.rb'
- 'spec/models/program_spec.rb'
- 'spec/models/track_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/pdfs/ticket_pdf_spec.rb'
# Offense count: 1 # Offense count: 1
RSpec/OverwritingSetup: RSpec/OverwritingSetup:
@ -1005,7 +1001,7 @@ RSpec/ReturnFromStub:
Exclude: Exclude:
- 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb'
# Offense count: 19 # Offense count: 18
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
RSpec/ScatteredLet: RSpec/ScatteredLet:
Exclude: Exclude:
@ -1018,7 +1014,7 @@ RSpec/ScatteredSetup:
Exclude: Exclude:
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
# Offense count: 32 # Offense count: 30
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
RSpec/SortMetadata: RSpec/SortMetadata:
Exclude: Exclude:
@ -1069,11 +1065,10 @@ RSpec/VoidExpect:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 3 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
RSpecRails/AvoidSetupHook: RSpecRails/AvoidSetupHook:
Exclude: Exclude:
- 'spec/features/versions_spec.rb'
- 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb'
# Offense count: 2 # Offense count: 2
@ -1101,7 +1096,7 @@ RSpecRails/InferredSpecType:
- 'spec/helpers/users_helper_spec.rb' - 'spec/helpers/users_helper_spec.rb'
- 'spec/routing/routing_spec.rb' - 'spec/routing/routing_spec.rb'
# Offense count: 24 # Offense count: 23
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: ExpectedOrder, Include. # Configuration parameters: ExpectedOrder, Include.
# ExpectedOrder: index, show, new, edit, create, update, destroy # ExpectedOrder: index, show, new, edit, create, update, destroy
@ -1276,7 +1271,7 @@ Rails/FilePath:
- 'spec/features/sponsor_spec.rb' - 'spec/features/sponsor_spec.rb'
- 'spec/support/deprecation_shitlist.rb' - 'spec/support/deprecation_shitlist.rb'
# Offense count: 81 # Offense count: 80
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AllowedMethods, AllowedPatterns. # Configuration parameters: AllowedMethods, AllowedPatterns.
# AllowedMethods: order, limit, select, lock # AllowedMethods: order, limit, select, lock
@ -1322,7 +1317,7 @@ Rails/HttpStatus:
- 'app/controllers/admin/venue_commercials_controller.rb' - 'app/controllers/admin/venue_commercials_controller.rb'
- 'app/controllers/commercials_controller.rb' - 'app/controllers/commercials_controller.rb'
# Offense count: 102 # Offense count: 99
Rails/I18nLocaleTexts: Rails/I18nLocaleTexts:
Enabled: false Enabled: false
@ -1396,13 +1391,12 @@ Rails/Present:
- 'app/models/program.rb' - 'app/models/program.rb'
- 'app/models/venue.rb' - 'app/models/venue.rb'
# Offense count: 6 # Offense count: 5
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: **/Rakefile, **/*.rake # Include: **/Rakefile, **/*.rake
Rails/RakeEnvironment: Rails/RakeEnvironment:
Exclude: Exclude:
- 'lib/tasks/dump_db.rake'
- 'lib/tasks/spec.rake' - 'lib/tasks/spec.rake'
# Offense count: 1 # Offense count: 1
@ -1413,10 +1407,25 @@ Rails/RedundantActiveRecordAllMethod:
Exclude: Exclude:
- 'db/migrate/20160309182655_remove_dietary_choices_table.rb' - 'db/migrate/20160309182655_remove_dietary_choices_table.rb'
# Offense count: 20 # Offense count: 19
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
Rails/RedundantPresenceValidationOnBelongsTo: Rails/RedundantPresenceValidationOnBelongsTo:
Enabled: false Exclude:
- 'app/models/booth.rb'
- 'app/models/cfp.rb'
- 'app/models/comment.rb'
- 'app/models/contact.rb'
- 'app/models/event.rb'
- 'app/models/event_schedule.rb'
- 'app/models/events_registration.rb'
- 'app/models/payment.rb'
- 'app/models/qanswer.rb'
- 'app/models/question.rb'
- 'app/models/registration.rb'
- 'app/models/room.rb'
- 'app/models/sponsor.rb'
- 'app/models/survey_reply.rb'
- 'app/models/ticket_purchase.rb'
# Offense count: 2 # Offense count: 2
Rails/RenderInline: Rails/RenderInline:
@ -1458,7 +1467,7 @@ Rails/SkipsModelValidations:
Rails/ThreeStateBooleanColumn: Rails/ThreeStateBooleanColumn:
Enabled: false Enabled: false
# Offense count: 48 # Offense count: 47
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible # SupportedStyles: strict, flexible
@ -1469,7 +1478,6 @@ Rails/TimeZone:
- 'config/environments/test.rb' - 'config/environments/test.rb'
- 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb' - 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb'
- 'db/migrate/20180313012253_add_timestamps_to_tickets.rb' - 'db/migrate/20180313012253_add_timestamps_to_tickets.rb'
- 'lib/tasks/dump_db.rake'
- 'spec/controllers/admin/comments_controller_spec.rb' - 'spec/controllers/admin/comments_controller_spec.rb'
- 'spec/factories/users.rb' - 'spec/factories/users.rb'
- 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/application_helper_spec.rb'
@ -1482,7 +1490,7 @@ Rails/TopLevelHashWithIndifferentAccess:
Exclude: Exclude:
- 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
# Offense count: 13 # Offense count: 12
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/models/**/*.rb # Include: app/models/**/*.rb
Rails/UniqueValidationWithoutIndex: Rails/UniqueValidationWithoutIndex:
@ -1492,7 +1500,6 @@ Rails/UniqueValidationWithoutIndex:
- 'app/models/commercial.rb' - 'app/models/commercial.rb'
- 'app/models/conference.rb' - 'app/models/conference.rb'
- 'app/models/events_registration.rb' - 'app/models/events_registration.rb'
- 'app/models/organization.rb'
- 'app/models/registration.rb' - 'app/models/registration.rb'
- 'app/models/role.rb' - 'app/models/role.rb'
- 'app/models/subscription.rb' - 'app/models/subscription.rb'
@ -1594,7 +1601,7 @@ Style/ConditionalAssignment:
- 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140610165551_migrate_data_person_to_user.rb'
- 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb'
# Offense count: 518 # Offense count: 517
# Configuration parameters: AllowedConstants. # Configuration parameters: AllowedConstants.
Style/Documentation: Style/Documentation:
Enabled: false Enabled: false
@ -1639,7 +1646,7 @@ Style/ExpandPathArguments:
Exclude: Exclude:
- 'spec/spec_helper.rb' - 'spec/spec_helper.rb'
# Offense count: 36 # Offense count: 38
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: always, always_true, never # SupportedStyles: always, always_true, never
@ -1652,7 +1659,7 @@ Style/GlobalStdStream:
Exclude: Exclude:
- 'config/environments/production.rb' - 'config/environments/production.rb'
# Offense count: 28 # Offense count: 27
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
Style/GuardClause: Style/GuardClause:
@ -1682,11 +1689,11 @@ Style/HashLikeCase:
Exclude: Exclude:
- 'app/helpers/versions_helper.rb' - 'app/helpers/versions_helper.rb'
# Offense count: 367 # Offense count: 346
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
# SupportedShorthandSyntax: always, never, either, consistent # SupportedShorthandSyntax: always, never, either, consistent, either_consistent
Style/HashSyntax: Style/HashSyntax:
Enabled: false Enabled: false
@ -1697,18 +1704,11 @@ Style/HashTransformValues:
- 'app/controllers/admin/comments_controller.rb' - 'app/controllers/admin/comments_controller.rb'
- 'app/helpers/chart_helper.rb' - 'app/helpers/chart_helper.rb'
# Offense count: 57 # Offense count: 56
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
Style/IfUnlessModifier: Style/IfUnlessModifier:
Enabled: false Enabled: false
# Offense count: 8
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/LineEndConcatenation:
Exclude:
- 'spec/features/conference_spec.rb'
- 'spec/features/registration_periods_spec.rb'
# Offense count: 1 # Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
Style/MapToHash: Style/MapToHash:
@ -1928,14 +1928,13 @@ Style/RedundantParentheses:
- 'app/models/venue.rb' - 'app/models/venue.rb'
- 'lib/tasks/version.rake' - 'lib/tasks/version.rake'
# Offense count: 3 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowMultipleReturnValues. # Configuration parameters: AllowMultipleReturnValues.
Style/RedundantReturn: Style/RedundantReturn:
Exclude: Exclude:
- 'app/controllers/admin/booths_controller.rb' - 'app/controllers/admin/booths_controller.rb'
- 'app/controllers/admin/events_controller.rb' - 'app/controllers/admin/events_controller.rb'
- 'app/controllers/admin/organizations_controller.rb'
# Offense count: 2 # Offense count: 2
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
@ -1981,13 +1980,27 @@ Style/SoleNestedConditional:
- 'db/migrate/20140801170430_move_event_media_to_commercial.rb' - 'db/migrate/20140801170430_move_event_media_to_commercial.rb'
- 'db/migrate/20151018152439_create_programs_table.rb' - 'db/migrate/20151018152439_create_programs_table.rb'
# Offense count: 28 # Offense count: 20
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Mode. # Configuration parameters: Mode.
Style/StringConcatenation: Style/StringConcatenation:
Enabled: false Exclude:
- 'app/controllers/admin/commercials_controller.rb'
- 'app/controllers/admin/conferences_controller.rb'
- 'app/controllers/admin/events_controller.rb'
- 'app/controllers/admin/roles_controller.rb'
- 'app/controllers/admin/surveys_controller.rb'
- 'app/controllers/payments_controller.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/users_helper.rb'
- 'app/helpers/versions_helper.rb'
- 'app/models/commercial.rb'
- 'app/models/conference.rb'
- 'lib/tasks/data.rake'
- 'spec/features/contact_spec.rb'
- 'spec/helpers/events_helper_spec.rb'
# Offense count: 16 # Offense count: 12
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
@ -1997,12 +2010,11 @@ Style/StringLiterals:
- 'config/deploy.rb' - 'config/deploy.rb'
- 'config/environments/production.rb' - 'config/environments/production.rb'
- 'config/puma.rb' - 'config/puma.rb'
- 'lib/tasks/dump_db.rake'
- 'lib/tasks/events_registrations.rake' - 'lib/tasks/events_registrations.rake'
- 'lib/tasks/factory_bot.rake' - 'lib/tasks/factory_bot.rake'
- 'lib/tasks/user.rake' - 'lib/tasks/user.rake'
# Offense count: 14 # Offense count: 8
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
@ -2011,9 +2023,8 @@ Style/StringLiteralsInInterpolation:
- 'app/views/admin/events/_all_events.xlsx.axlsx' - 'app/views/admin/events/_all_events.xlsx.axlsx'
- 'app/views/admin/events/_all_with_comments.xlsx.axlsx' - 'app/views/admin/events/_all_with_comments.xlsx.axlsx'
- 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - 'app/views/admin/events/_confirmed_events.xlsx.axlsx'
- 'lib/tasks/dump_db.rake'
# Offense count: 110 # Offense count: 105
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, MinSize. # Configuration parameters: EnforcedStyle, MinSize.
# SupportedStyles: percent, brackets # SupportedStyles: percent, brackets
@ -2059,7 +2070,7 @@ Style/WordArray:
EnforcedStyle: percent EnforcedStyle: percent
MinSize: 6 MinSize: 6
# Offense count: 525 # Offense count: 497
# This cop supports safe autocorrection (--autocorrect). # This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https # URISchemes: http, https