From 8a131917d92c039e22da8d52bdc3efee5cd5b5ff Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Tue, 5 Mar 2024 17:19:42 +0000 Subject: [PATCH 1/2] Update rubocop-rails to version 2.24.0 --- Gemfile.lock | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index 3a03f338..5ce9b164 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -489,10 +489,11 @@ GEM rubocop-performance (1.20.2) rubocop (>= 1.48.1, < 2.0) rubocop-ast (>= 1.30.0, < 2.0) - rubocop-rails (2.19.1) + rubocop-rails (2.24.0) activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) + rubocop-ast (>= 1.31.1, < 2.0) rubocop-rspec (2.23.0) rubocop (~> 1.33) rubocop-capybara (~> 2.17) From 66fa4994a0a9cf82e0514e7c34addff3864bf48e Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Tue, 26 Mar 2024 11:26:40 +0100 Subject: [PATCH 2/2] Update rubocop TODO --- .rubocop_todo.yml | 40 +++++++++++++++++++++++++++++++++------- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7e343ea1..141951ef 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-03-04 16:04:49 UTC using RuboCop version 1.61.0. +# on 2024-03-26 10:26:16 UTC using RuboCop version 1.61.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -1146,7 +1146,7 @@ Rails/ContentTag: # Offense count: 13 # Configuration parameters: Include. -# Include: db/migrate/*.rb +# Include: db/**/*.rb Rails/CreateTableWithTimestamps: Exclude: - 'db/migrate/20121223115117_create_rooms_table.rb' @@ -1163,7 +1163,16 @@ Rails/CreateTableWithTimestamps: - 'db/migrate/20170129075434_create_resources_table.rb' - 'db/migrate/20170529215453_create_organizations.rb' +# Offense count: 2 +# Configuration parameters: Severity, Include. +# Include: db/**/*.rb +Rails/DangerousColumnNames: + Exclude: + - 'db/migrate/20160403214841_add_id_and_created_at_to_events_registrations.rb' + - 'db/migrate/20160614145614_add_id_to_users_roles.rb' + # Offense count: 103 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle, AllowToTime. # SupportedStyles: strict, flexible Rails/Date: @@ -1224,6 +1233,7 @@ Rails/EnumHash: - 'app/models/survey_question.rb' # Offense count: 7 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments Rails/FilePath: @@ -1235,6 +1245,13 @@ Rails/FilePath: - 'spec/features/sponsor_spec.rb' - 'spec/support/deprecation_shitlist.rb' +# Offense count: 81 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowedMethods, AllowedPatterns. +# AllowedMethods: order, limit, select, lock +Rails/FindEach: + Enabled: false + # Offense count: 6 # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -1274,7 +1291,7 @@ Rails/HttpStatus: - 'app/controllers/admin/venue_commercials_controller.rb' - 'app/controllers/commercials_controller.rb' -# Offense count: 100 +# Offense count: 102 Rails/I18nLocaleTexts: Enabled: false @@ -1357,7 +1374,15 @@ Rails/RakeEnvironment: - 'lib/tasks/dump_db.rake' - 'lib/tasks/spec.rake' -# Offense count: 21 +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowedReceivers. +# AllowedReceivers: ActionMailer::Preview, ActiveSupport::TimeZone +Rails/RedundantActiveRecordAllMethod: + Exclude: + - 'db/migrate/20160309182655_remove_dietary_choices_table.rb' + +# Offense count: 20 # This cop supports unsafe autocorrection (--autocorrect-all). Rails/RedundantPresenceValidationOnBelongsTo: Enabled: false @@ -1402,7 +1427,7 @@ Rails/SkipsModelValidations: Rails/ThreeStateBooleanColumn: Enabled: false -# Offense count: 40 +# Offense count: 48 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible @@ -1416,6 +1441,7 @@ Rails/TimeZone: - 'lib/tasks/dump_db.rake' - 'spec/controllers/admin/comments_controller_spec.rb' - 'spec/factories/users.rb' + - 'spec/helpers/application_helper_spec.rb' - 'spec/models/conference_spec.rb' # Offense count: 1 @@ -1630,7 +1656,7 @@ Style/HashTransformValues: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 58 +# Offense count: 57 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false @@ -1920,7 +1946,7 @@ Style/SoleNestedConditional: Style/StringConcatenation: Enabled: false -# Offense count: 17 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes