From 2302821c48ef690e5a8133baa3a5aab8d3953f92 Mon Sep 17 00:00:00 2001 From: Carlos Coelho Date: Fri, 4 Mar 2016 11:09:50 -0300 Subject: [PATCH] Extract method of proposal submission related to openSUSE/osem#597 Signed-off-by: Carlos Coelho --- app/controllers/proposal_controller.rb | 30 +++++++++++++++----------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/app/controllers/proposal_controller.rb b/app/controllers/proposal_controller.rb index 64e34196..c3e16e36 100644 --- a/app/controllers/proposal_controller.rb +++ b/app/controllers/proposal_controller.rb @@ -30,19 +30,7 @@ class ProposalController < ApplicationController params[:event].delete :user - @event = Event.new(event_params) - @event.program = @program - - @event.event_users.new(user: current_user, - event_role: 'submitter') - @event.event_users.new(user: current_user, - event_role: 'speaker') - - unless @event.save - flash[:error] = "Could not submit proposal: #{@event.errors.full_messages.join(', ')}" - render action: 'new' - return - end + proposal_submission ahoy.track 'Event submission', title: 'New submission' @@ -150,6 +138,22 @@ class ProposalController < ApplicationController end end end + + def proposal_submission + @event = Event.new(event_params) + @event.program = @program + + @event.event_users.new(user: current_user, + event_role: 'submitter') + @event.event_users.new(user: current_user, + event_role: 'speaker') + + unless @event.save + flash[:error] = "Could not submit proposal: #{@event.errors.full_messages.join(', ')}" + render action: 'new' + return + end + end end # FIXME: Introduce strong_parameters pronto!