From 011b4d576af2791b95db5f9230c8c92fcc90804d Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Tue, 21 Mar 2017 21:08:53 +0200
Subject: [PATCH 1/8] Create links for speakers in admin/reports#index

---
 app/views/admin/reports/_all_events.html.haml             | 8 +++++++-
 .../admin/reports/_events_with_requirements.html.haml     | 6 +++++-
 .../admin/reports/_events_without_commercials.html.haml   | 6 +++++-
 3 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/app/views/admin/reports/_all_events.html.haml b/app/views/admin/reports/_all_events.html.haml
index 6aef4178..7a5f5380 100644
--- a/app/views/admin/reports/_all_events.html.haml
+++ b/app/views/admin/reports/_all_events.html.haml
@@ -27,7 +27,13 @@
           %td
             = link_to event.title, edit_admin_conference_program_event_path(@conference.short_title, event)
             %br
-            .small (Presented by #{event.speaker_names})
+            .small
+              (Presented by
+              - speakers = event.speakers.uniq
+              - speakers.each.with_index(1) do |speaker,index|
+                = link_to speaker.name, admin_user_path(speaker)
+                = ',' unless index == speakers.length
+              )
 
           - %w(registered biography commercials subtitle difficulty_level).each do |info|
             %td{'data-order' => "#{progress_status[info]}"}
diff --git a/app/views/admin/reports/_events_with_requirements.html.haml b/app/views/admin/reports/_events_with_requirements.html.haml
index b0759af8..7bebe2b2 100644
--- a/app/views/admin/reports/_events_with_requirements.html.haml
+++ b/app/views/admin/reports/_events_with_requirements.html.haml
@@ -21,7 +21,11 @@
         %tr
           %td= event.id
           %td= link_to event.title, edit_admin_conference_program_event_path(@conference.short_title, event)
-          %td  #{event.speaker_names}
+          %td
+            - speakers = event.speakers.uniq
+            - speakers.each.with_index(1) do |speaker,index|
+              = link_to speaker.name, admin_user_path(speaker)
+              = ',' unless index == speakers.length
           %td= event.description
           %td= event.room.name if event.room
           %td= event.time.to_date if event.time
diff --git a/app/views/admin/reports/_events_without_commercials.html.haml b/app/views/admin/reports/_events_without_commercials.html.haml
index 1aaff358..798f3d4a 100644
--- a/app/views/admin/reports/_events_without_commercials.html.haml
+++ b/app/views/admin/reports/_events_without_commercials.html.haml
@@ -17,4 +17,8 @@
         %tr
           %td= event.id
           %td= link_to event.title, edit_admin_conference_program_event_path(@conference.short_title, event)
-          %td  #{event.speaker_names}
+          %td
+            - speakers = event.speakers.uniq
+            - speakers.each.with_index(1) do |speaker,index|
+              = link_to speaker.name, admin_user_path(speaker)
+              = ',' unless index == speakers.length

From d92c489fa9eea5cf2109bc538d72a06ca9c3d281 Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Mon, 17 Apr 2017 14:17:29 +0300
Subject: [PATCH 2/8] Add disabled for list-group-item in todolist

---
 .../admin/conferences/_todo_list.html.haml     | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/views/admin/conferences/_todo_list.html.haml b/app/views/admin/conferences/_todo_list.html.haml
index cd98391d..b70e497d 100644
--- a/app/views/admin/conferences/_todo_list.html.haml
+++ b/app/views/admin/conferences/_todo_list.html.haml
@@ -1,12 +1,12 @@
 .list-group
-  %li.list-group-item
+  %li{ 'class' => "list-group-item disabled" }
     %h4
       Conference progress
     .progress
       .progress-bar{ 'role' => 'progressbar', 'aria-valuenow' => "#{conference_progress['process']}", 'aria-valuemin' => '0',
                     'aria-valuemax' => '100', 'style' => "width: #{conference_progress['process']}%;" }
         = conference_progress['process'] + '%'
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['registration'])}" }
+  %li{ 'class' => "list-group-item disabled  #{class_for_todo(conference_progress['registration'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['registration']) }
     - if can? :update, @conference
       - if conference.registration_period
@@ -15,13 +15,13 @@
         = link_to 'Set up registration period', new_admin_conference_registration_period_path(conference_progress['short_title'])
     - else
       Set up registration period
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['cfp'])}" }
+  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['cfp'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['cfp']) }
     - if can? :update, Cfp.new(program_id: @program.id)
       = link_to 'Set up call for papers', admin_conference_program_cfp_path(conference_progress['short_title'])
     - else
       Set up call for papers
-  %li{'class'=>"list-group-item #{class_for_todo(conference_progress['venue'])}"}
+  %li{'class'=>"list-group-item disabled #{class_for_todo(conference_progress['venue'])}"}
     %span{'class'=>icon_for_todo(conference_progress['venue'])}
     - if can? :update, Venue.new(conference: @conference)
       - @conference.reload
@@ -32,31 +32,31 @@
     - else
       - @conference.reload
       Add venue
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['rooms'])}" }
+  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['rooms'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['rooms']) }
     - if @conference.venue && (can? :update, @conference.venue.rooms.build)
       = link_to 'Add rooms', admin_conference_venue_rooms_path(conference_progress['short_title'])
     - else
       Add rooms
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['tracks'])}" }
+  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['tracks'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['tracks']) }
     - if can? :update, @conference.program.tracks.build
       = link_to 'Add tracks', admin_conference_program_tracks_path(conference_progress['short_title'])
     - else
       Add tracks
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['event_types'])}" }
+  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['event_types'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['event_types']) }
     - if can? :update, @conference.program.event_types.build
       = link_to 'Add event types', admin_conference_program_event_types_path(conference_progress['short_title'])
     - else
       Add event types
-  %li{ 'class' => "list-group-item #{class_for_todo(conference_progress['difficulty_levels'])}" }
+  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['difficulty_levels'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['difficulty_levels']) }
     - if can? :update, @conference.program.difficulty_levels.build
       = link_to 'Add difficulty levels', admin_conference_program_difficulty_levels_path(conference_progress['short_title'])
     - else
       Add difficulty levels
-  %li{ class: "list-group-item #{class_for_todo(conference_progress['splashpage'])}" }
+  %li{ class: "list-group-item disabled #{class_for_todo(conference_progress['splashpage'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['splashpage']) }
     - if can? :update, @conference
       = link_to 'Set up a Splashpage', admin_conference_splashpage_path(conference_progress['short_title'])

From 043e20ea015e830286edd6c1c339f44878fc6459 Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Mon, 17 Apr 2017 14:27:26 +0300
Subject: [PATCH 3/8] Add disabled to li for recent submissions/registrations

---
 app/views/admin/conferences/show.html.haml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/admin/conferences/show.html.haml b/app/views/admin/conferences/show.html.haml
index dec58da8..48907c35 100644
--- a/app/views/admin/conferences/show.html.haml
+++ b/app/views/admin/conferences/show.html.haml
@@ -101,11 +101,11 @@
 .row
   .col-md-8
     %ul.nav.nav-tabs#recentTable
-      %li.active
+      %li{ 'class' => "active disabled" }
         %a{ href: '#recent_reg', 'data-toggle' => 'tab' }
           %span.fa.fa-user
           Recent Registrations
-      %li
+      %li{ 'class' => "disabled" }
         %a{ href: '#recent_submissions', 'data-toggle' => 'tab' }
           %span.fa.fa-file-text
           Recent Submissions

From 4b855a22dcecef8876bb96e64ae634ff7f75e2d6 Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Sat, 22 Apr 2017 17:50:19 +0300
Subject: [PATCH 4/8] Hide todo list when conference is over

---
 .../admin/conferences/_todo_list.html.haml     | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/views/admin/conferences/_todo_list.html.haml b/app/views/admin/conferences/_todo_list.html.haml
index b70e497d..45f7b1fe 100644
--- a/app/views/admin/conferences/_todo_list.html.haml
+++ b/app/views/admin/conferences/_todo_list.html.haml
@@ -1,12 +1,12 @@
 .list-group
-  %li{ 'class' => "list-group-item disabled" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date }" }
     %h4
       Conference progress
     .progress
       .progress-bar{ 'role' => 'progressbar', 'aria-valuenow' => "#{conference_progress['process']}", 'aria-valuemin' => '0',
                     'aria-valuemax' => '100', 'style' => "width: #{conference_progress['process']}%;" }
         = conference_progress['process'] + '%'
-  %li{ 'class' => "list-group-item disabled  #{class_for_todo(conference_progress['registration'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date }  #{class_for_todo(conference_progress['registration'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['registration']) }
     - if can? :update, @conference
       - if conference.registration_period
@@ -15,13 +15,13 @@
         = link_to 'Set up registration period', new_admin_conference_registration_period_path(conference_progress['short_title'])
     - else
       Set up registration period
-  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['cfp'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['cfp'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['cfp']) }
     - if can? :update, Cfp.new(program_id: @program.id)
       = link_to 'Set up call for papers', admin_conference_program_cfp_path(conference_progress['short_title'])
     - else
       Set up call for papers
-  %li{'class'=>"list-group-item disabled #{class_for_todo(conference_progress['venue'])}"}
+  %li{'class'=>"list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['venue'])}"}
     %span{'class'=>icon_for_todo(conference_progress['venue'])}
     - if can? :update, Venue.new(conference: @conference)
       - @conference.reload
@@ -32,31 +32,31 @@
     - else
       - @conference.reload
       Add venue
-  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['rooms'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['rooms'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['rooms']) }
     - if @conference.venue && (can? :update, @conference.venue.rooms.build)
       = link_to 'Add rooms', admin_conference_venue_rooms_path(conference_progress['short_title'])
     - else
       Add rooms
-  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['tracks'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['tracks'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['tracks']) }
     - if can? :update, @conference.program.tracks.build
       = link_to 'Add tracks', admin_conference_program_tracks_path(conference_progress['short_title'])
     - else
       Add tracks
-  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['event_types'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['event_types'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['event_types']) }
     - if can? :update, @conference.program.event_types.build
       = link_to 'Add event types', admin_conference_program_event_types_path(conference_progress['short_title'])
     - else
       Add event types
-  %li{ 'class' => "list-group-item disabled #{class_for_todo(conference_progress['difficulty_levels'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['difficulty_levels'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['difficulty_levels']) }
     - if can? :update, @conference.program.difficulty_levels.build
       = link_to 'Add difficulty levels', admin_conference_program_difficulty_levels_path(conference_progress['short_title'])
     - else
       Add difficulty levels
-  %li{ class: "list-group-item disabled #{class_for_todo(conference_progress['splashpage'])}" }
+  %li{ class: "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['splashpage'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['splashpage']) }
     - if can? :update, @conference
       = link_to 'Set up a Splashpage', admin_conference_splashpage_path(conference_progress['short_title'])

From cb71b72e136200f083e0694006d1afc0282fe30b Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Sat, 22 Apr 2017 18:36:38 +0300
Subject: [PATCH 5/8] Hide recent Registrations/Submissions when conference is
 over

---
 app/views/admin/conferences/show.html.haml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/views/admin/conferences/show.html.haml b/app/views/admin/conferences/show.html.haml
index 48907c35..7d10c98b 100644
--- a/app/views/admin/conferences/show.html.haml
+++ b/app/views/admin/conferences/show.html.haml
@@ -101,11 +101,11 @@
 .row
   .col-md-8
     %ul.nav.nav-tabs#recentTable
-      %li{ 'class' => "active disabled" }
+      %li{ 'class' => "active #{ 'hidden' if Date.today >= @conference.end_date }" }
         %a{ href: '#recent_reg', 'data-toggle' => 'tab' }
           %span.fa.fa-user
           Recent Registrations
-      %li{ 'class' => "disabled" }
+      %li{ 'class' => "#{ 'hidden' if Date.today >= @conference.end_date }" }
         %a{ href: '#recent_submissions', 'data-toggle' => 'tab' }
           %span.fa.fa-file-text
           Recent Submissions

From b53b7b2eb39bf53fc5ec37ec772fba3d1b5aae78 Mon Sep 17 00:00:00 2001
From: selini <selini@softweb.gr>
Date: Tue, 25 Apr 2017 19:50:14 +0300
Subject: [PATCH 6/8] Remove equal from check if conference is over

---
 app/views/admin/conferences/_todo_list.html.haml | 12 ++++++------
 app/views/admin/conferences/show.html.haml       |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/views/admin/conferences/_todo_list.html.haml b/app/views/admin/conferences/_todo_list.html.haml
index 45f7b1fe..70b543c5 100644
--- a/app/views/admin/conferences/_todo_list.html.haml
+++ b/app/views/admin/conferences/_todo_list.html.haml
@@ -15,7 +15,7 @@
         = link_to 'Set up registration period', new_admin_conference_registration_period_path(conference_progress['short_title'])
     - else
       Set up registration period
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['cfp'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['cfp'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['cfp']) }
     - if can? :update, Cfp.new(program_id: @program.id)
       = link_to 'Set up call for papers', admin_conference_program_cfp_path(conference_progress['short_title'])
@@ -32,31 +32,31 @@
     - else
       - @conference.reload
       Add venue
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['rooms'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['rooms'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['rooms']) }
     - if @conference.venue && (can? :update, @conference.venue.rooms.build)
       = link_to 'Add rooms', admin_conference_venue_rooms_path(conference_progress['short_title'])
     - else
       Add rooms
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['tracks'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['tracks'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['tracks']) }
     - if can? :update, @conference.program.tracks.build
       = link_to 'Add tracks', admin_conference_program_tracks_path(conference_progress['short_title'])
     - else
       Add tracks
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['event_types'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['event_types'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['event_types']) }
     - if can? :update, @conference.program.event_types.build
       = link_to 'Add event types', admin_conference_program_event_types_path(conference_progress['short_title'])
     - else
       Add event types
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['difficulty_levels'])}" }
+  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['difficulty_levels'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['difficulty_levels']) }
     - if can? :update, @conference.program.difficulty_levels.build
       = link_to 'Add difficulty levels', admin_conference_program_difficulty_levels_path(conference_progress['short_title'])
     - else
       Add difficulty levels
-  %li{ class: "list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['splashpage'])}" }
+  %li{ class: "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['splashpage'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['splashpage']) }
     - if can? :update, @conference
       = link_to 'Set up a Splashpage', admin_conference_splashpage_path(conference_progress['short_title'])
diff --git a/app/views/admin/conferences/show.html.haml b/app/views/admin/conferences/show.html.haml
index 7d10c98b..d38592a2 100644
--- a/app/views/admin/conferences/show.html.haml
+++ b/app/views/admin/conferences/show.html.haml
@@ -101,11 +101,11 @@
 .row
   .col-md-8
     %ul.nav.nav-tabs#recentTable
-      %li{ 'class' => "active #{ 'hidden' if Date.today >= @conference.end_date }" }
+      %li{ 'class' => "active #{ 'hidden' if Date.today > @conference.end_date }" }
         %a{ href: '#recent_reg', 'data-toggle' => 'tab' }
           %span.fa.fa-user
           Recent Registrations
-      %li{ 'class' => "#{ 'hidden' if Date.today >= @conference.end_date }" }
+      %li{ 'class' => "#{ 'hidden' if Date.today > @conference.end_date }" }
         %a{ href: '#recent_submissions', 'data-toggle' => 'tab' }
           %span.fa.fa-file-text
           Recent Submissions

From 8ce3cdcd6c8bad9f3898c52370e4289b1bce38f2 Mon Sep 17 00:00:00 2001
From: Alator <tazz_133@windowslive.com>
Date: Tue, 2 May 2017 20:57:06 +0300
Subject: [PATCH 7/8] Refactoring code and add method

---
 app/helpers/application_helper.rb              |  6 ++++++
 .../admin/conferences/_todo_list.html.haml     | 18 +++++++++---------
 app/views/admin/conferences/show.html.haml     |  4 ++--
 3 files changed, 17 insertions(+), 11 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index c82e6bab..b948281d 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -597,4 +597,10 @@ module ApplicationHelper
     end
     concurrent_events
   end
+
+  def set_hidden_if_conf_is_over(conference)
+    'hidden' if Date.today > conference.end_date
+  end
+
 end
+
diff --git a/app/views/admin/conferences/_todo_list.html.haml b/app/views/admin/conferences/_todo_list.html.haml
index 70b543c5..4b88b814 100644
--- a/app/views/admin/conferences/_todo_list.html.haml
+++ b/app/views/admin/conferences/_todo_list.html.haml
@@ -1,12 +1,12 @@
 .list-group
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date }" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}" }
     %h4
       Conference progress
     .progress
       .progress-bar{ 'role' => 'progressbar', 'aria-valuenow' => "#{conference_progress['process']}", 'aria-valuemin' => '0',
                     'aria-valuemax' => '100', 'style' => "width: #{conference_progress['process']}%;" }
         = conference_progress['process'] + '%'
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today >= conference.end_date }  #{class_for_todo(conference_progress['registration'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}  #{class_for_todo(conference_progress['registration'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['registration']) }
     - if can? :update, @conference
       - if conference.registration_period
@@ -15,13 +15,13 @@
         = link_to 'Set up registration period', new_admin_conference_registration_period_path(conference_progress['short_title'])
     - else
       Set up registration period
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['cfp'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}  #{class_for_todo(conference_progress['cfp'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['cfp']) }
     - if can? :update, Cfp.new(program_id: @program.id)
       = link_to 'Set up call for papers', admin_conference_program_cfp_path(conference_progress['short_title'])
     - else
       Set up call for papers
-  %li{'class'=>"list-group-item #{ 'hidden' if Date.today >= conference.end_date } #{class_for_todo(conference_progress['venue'])}"}
+  %li{'class'=>"list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['venue'])}"}
     %span{'class'=>icon_for_todo(conference_progress['venue'])}
     - if can? :update, Venue.new(conference: @conference)
       - @conference.reload
@@ -32,31 +32,31 @@
     - else
       - @conference.reload
       Add venue
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['rooms'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['rooms'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['rooms']) }
     - if @conference.venue && (can? :update, @conference.venue.rooms.build)
       = link_to 'Add rooms', admin_conference_venue_rooms_path(conference_progress['short_title'])
     - else
       Add rooms
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['tracks'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['tracks'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['tracks']) }
     - if can? :update, @conference.program.tracks.build
       = link_to 'Add tracks', admin_conference_program_tracks_path(conference_progress['short_title'])
     - else
       Add tracks
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['event_types'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['event_types'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['event_types']) }
     - if can? :update, @conference.program.event_types.build
       = link_to 'Add event types', admin_conference_program_event_types_path(conference_progress['short_title'])
     - else
       Add event types
-  %li{ 'class' => "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['difficulty_levels'])}" }
+  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['difficulty_levels'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['difficulty_levels']) }
     - if can? :update, @conference.program.difficulty_levels.build
       = link_to 'Add difficulty levels', admin_conference_program_difficulty_levels_path(conference_progress['short_title'])
     - else
       Add difficulty levels
-  %li{ class: "list-group-item #{ 'hidden' if Date.today > conference.end_date } #{class_for_todo(conference_progress['splashpage'])}" }
+  %li{ class: "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['splashpage'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['splashpage']) }
     - if can? :update, @conference
       = link_to 'Set up a Splashpage', admin_conference_splashpage_path(conference_progress['short_title'])
diff --git a/app/views/admin/conferences/show.html.haml b/app/views/admin/conferences/show.html.haml
index d38592a2..d6bebfea 100644
--- a/app/views/admin/conferences/show.html.haml
+++ b/app/views/admin/conferences/show.html.haml
@@ -101,11 +101,11 @@
 .row
   .col-md-8
     %ul.nav.nav-tabs#recentTable
-      %li{ 'class' => "active #{ 'hidden' if Date.today > @conference.end_date }" }
+      %li{ 'class' => "active #{set_hidden_if_conf_is_over(@conference)}" }
         %a{ href: '#recent_reg', 'data-toggle' => 'tab' }
           %span.fa.fa-user
           Recent Registrations
-      %li{ 'class' => "#{ 'hidden' if Date.today > @conference.end_date }" }
+      %li{ 'class' => "#{set_hidden_if_conf_is_over(@conference)}" }
         %a{ href: '#recent_submissions', 'data-toggle' => 'tab' }
           %span.fa.fa-file-text
           Recent Submissions

From 3a1e1da9e7f7b7e72738f7f53117c52505b1b710 Mon Sep 17 00:00:00 2001
From: Alator <tazz_133@windowslive.com>
Date: Tue, 9 May 2017 19:44:24 +0300
Subject: [PATCH 8/8] Changed function name,added comments

---
 app/helpers/application_helper.rb              |  9 ++++++---
 .../admin/conferences/_todo_list.html.haml     | 18 +++++++++---------
 app/views/admin/conferences/show.html.haml     |  4 ++--
 3 files changed, 17 insertions(+), 14 deletions(-)

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index b948281d..f7957dc0 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -45,7 +45,7 @@ module ApplicationHelper
   def voting_open_or_close(program)
     return if program.voting_period?
     if program.voting_start_date > Time.current
-      return 'Voting period has not started yet!'
+      return 'Voting period has nmot started yet!'
     else # voting_end_date > Date.today because voting_start_date < voting_end_date
       return 'Voting period is over!'
     end
@@ -598,9 +598,12 @@ module ApplicationHelper
     concurrent_events
   end
 
-  def set_hidden_if_conf_is_over(conference)
+  ##
+  # ====Gets
+  # a conference object
+  # Sets class hidden if conference is over 
+  def hidden_if_conference_over(conference)
     'hidden' if Date.today > conference.end_date
   end
-
 end
 
diff --git a/app/views/admin/conferences/_todo_list.html.haml b/app/views/admin/conferences/_todo_list.html.haml
index 4b88b814..63f4e3aa 100644
--- a/app/views/admin/conferences/_todo_list.html.haml
+++ b/app/views/admin/conferences/_todo_list.html.haml
@@ -1,12 +1,12 @@
 .list-group
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)}" }
     %h4
       Conference progress
     .progress
       .progress-bar{ 'role' => 'progressbar', 'aria-valuenow' => "#{conference_progress['process']}", 'aria-valuemin' => '0',
                     'aria-valuemax' => '100', 'style' => "width: #{conference_progress['process']}%;" }
         = conference_progress['process'] + '%'
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}  #{class_for_todo(conference_progress['registration'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)}  #{class_for_todo(conference_progress['registration'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['registration']) }
     - if can? :update, @conference
       - if conference.registration_period
@@ -15,13 +15,13 @@
         = link_to 'Set up registration period', new_admin_conference_registration_period_path(conference_progress['short_title'])
     - else
       Set up registration period
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)}  #{class_for_todo(conference_progress['cfp'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)}  #{class_for_todo(conference_progress['cfp'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['cfp']) }
     - if can? :update, Cfp.new(program_id: @program.id)
       = link_to 'Set up call for papers', admin_conference_program_cfp_path(conference_progress['short_title'])
     - else
       Set up call for papers
-  %li{'class'=>"list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['venue'])}"}
+  %li{'class'=>"list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['venue'])}"}
     %span{'class'=>icon_for_todo(conference_progress['venue'])}
     - if can? :update, Venue.new(conference: @conference)
       - @conference.reload
@@ -32,31 +32,31 @@
     - else
       - @conference.reload
       Add venue
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['rooms'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['rooms'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['rooms']) }
     - if @conference.venue && (can? :update, @conference.venue.rooms.build)
       = link_to 'Add rooms', admin_conference_venue_rooms_path(conference_progress['short_title'])
     - else
       Add rooms
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['tracks'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['tracks'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['tracks']) }
     - if can? :update, @conference.program.tracks.build
       = link_to 'Add tracks', admin_conference_program_tracks_path(conference_progress['short_title'])
     - else
       Add tracks
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['event_types'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['event_types'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['event_types']) }
     - if can? :update, @conference.program.event_types.build
       = link_to 'Add event types', admin_conference_program_event_types_path(conference_progress['short_title'])
     - else
       Add event types
-  %li{ 'class' => "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['difficulty_levels'])}" }
+  %li{ 'class' => "list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['difficulty_levels'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['difficulty_levels']) }
     - if can? :update, @conference.program.difficulty_levels.build
       = link_to 'Add difficulty levels', admin_conference_program_difficulty_levels_path(conference_progress['short_title'])
     - else
       Add difficulty levels
-  %li{ class: "list-group-item #{set_hidden_if_conf_is_over(conference)} #{class_for_todo(conference_progress['splashpage'])}" }
+  %li{ class: "list-group-item #{hidden_if_conference_over(conference)} #{class_for_todo(conference_progress['splashpage'])}" }
     %span{ 'class' => icon_for_todo(conference_progress['splashpage']) }
     - if can? :update, @conference
       = link_to 'Set up a Splashpage', admin_conference_splashpage_path(conference_progress['short_title'])
diff --git a/app/views/admin/conferences/show.html.haml b/app/views/admin/conferences/show.html.haml
index d6bebfea..39d48f54 100644
--- a/app/views/admin/conferences/show.html.haml
+++ b/app/views/admin/conferences/show.html.haml
@@ -101,11 +101,11 @@
 .row
   .col-md-8
     %ul.nav.nav-tabs#recentTable
-      %li{ 'class' => "active #{set_hidden_if_conf_is_over(@conference)}" }
+      %li{ 'class' => "active #{hidden_if_conference_over(@conference)}" }
         %a{ href: '#recent_reg', 'data-toggle' => 'tab' }
           %span.fa.fa-user
           Recent Registrations
-      %li{ 'class' => "#{set_hidden_if_conf_is_over(@conference)}" }
+      %li{ 'class' => "#{hidden_if_conference_over(@conference)}" }
         %a{ href: '#recent_submissions', 'data-toggle' => 'tab' }
           %span.fa.fa-file-text
           Recent Submissions