Issue #649: Wrong days remaining label when submitting a new proposal

app/models/call_for_paper.rb

@@ -63,6 +63,11 @@ class CallForPaper < ActiveRecord::Base
     && !self.conference.email_settings.call_for_papers_dates_updates_template.blank?
   end
 
+  def remaining_days(date = Date.today)
+    result = (self.end_date - date).to_i
+    result > 0 ? result : 0
+  end
+
   private
 
   def before_end_of_conference

app/views/admin/call_for_papers/show.html.haml

@@ -19,8 +19,7 @@
         %dt
           Days Left:
         %dd
-          - days = (@call_for_paper.end_date - Date.today).to_i
+          = pluralize(@call_for_paper.remaining_days, 'day')
-          = pluralize(days, 'days')
         %dt
           Event types:
         %dd

app/views/conference/_call_for_paper.html.haml

@@ -25,14 +25,15 @@
         and closes
         %em
           = @conference.call_for_paper.end_date.strftime('%A, %B %-d. %Y.')
-        That means you have only
+        - if @conference.cfp_open?
-        - days = (@conference.call_for_paper.end_date - Date.today).to_i
+          That means you have only
-        %b
+          %b= pluralize(@conference.call_for_paper.remaining_days, 'day')
-          = pluralize(days, 'days')
           left!
-        Remember
+          Remember
-        = @conference.short_title
+          = @conference.short_title
-        will only be as good as the sessions you present. Submit early, submit often!
+          will only be as good as the sessions you present. Submit early, submit often!
+        - else
+          The submission period is closed.
   .row
     .col-md-12.text-center
       %p.cta-button

app/views/proposal/_encouragement_text.html.haml

@@ -6,18 +6,18 @@
     Proposals should fit in one of the
     = "#{pluralize(@conference.tracks.count, 'track')}:"
     = "#{tracks(@conference)}."
-  - if @conference.call_for_paper
+  - if @conference.cfp_open?
     The submission period has begun
     %em
       = @conference.call_for_paper.start_date.strftime('%A, %B %-d. %Y')
     and closes
     %em
       = @conference.call_for_paper.end_date.strftime('%A, %B %-d. %Y.')
-    That means you have only
+    That means you have
-    - days = (@conference.call_for_paper.end_date - Date.today).to_i
+    %b= pluralize(@conference.call_for_paper.remaining_days, 'day')
-    %b
+    left!
-      = pluralize(days, 'days')
+    Remember
-      left!
+    = @conference.title
-  Remember
+    will only be as good as the content you present. Submit early, submit often!
-  = @conference.title
+  -else
-  will only be as good as the content you present. Submit early, submit often!
+    The submission period is closed now.