From 1a1da83bf2a4f0b4e82c389271f40dcbad889598 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Tue, 5 Mar 2019 21:17:52 +0100 Subject: [PATCH] Document the ichain specific ability --- app/models/ability.rb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/app/models/ability.rb b/app/models/ability.rb index 4ae77007..47d68705 100644 --- a/app/models/ability.rb +++ b/app/models/ability.rb @@ -38,7 +38,14 @@ class Ability # can view Commercials of confirmed Events can :show, Commercial, commercialable_type: 'Event', commercialable_id: Event.where(state: 'confirmed').pluck(:id) can [:show, :create], User - unless ENV['OSEM_ICHAIN_ENABLED'] == 'true' + + # Things that are possible without ichain enabled that are **not*+ possible with ichain mode enabled. + if ENV['OSEM_ICHAIN_ENABLED'] != 'true' + # There is no reliable way for this workflow (enable not logged in users to fill out a form, then telling + # them to sign up once they submit) in ichain. So enable it only without ichain. + + # FIXME: The following abilities need to be checked. Are they about the type of workflow mentioned above? Or are + # they just here because they worked in development mode (without ichain). We are suspicious that it's the latter! can :show, Registration do |registration| registration.new_record? end