From 1563881153250125c30fde672a845c2ba3238a18 Mon Sep 17 00:00:00 2001 From: Andrew Kvalheim Date: Wed, 1 Mar 2023 11:43:50 -0800 Subject: [PATCH] Add user to cache dependencies of vote in events index MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When fragment caching is enabled— --- a/config/environments/test.rb +++ b/config/environments/test.rb @@ -27 +26,0 @@ - config.action_controller.perform_caching = false @@ -29 +27,0 @@ - config.cache_store = :null_store —the test of voting fails with: expected to find text "Not rated" in "…You voted: 3/5…" # ./spec/features/voting_spec.rb:15 # ./spec/features/voting_spec.rb:13 # ./spec/features/voting_spec.rb:57 i.e. the vote displayed on the event index is another user’s vote, because the fragment’s cache dependencies don’t include the current user. re #2767 --- app/views/admin/events/_datatable_row.haml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/admin/events/_datatable_row.haml b/app/views/admin/events/_datatable_row.haml index 7de3f3f1..17f7b264 100644 --- a/app/views/admin/events/_datatable_row.haml +++ b/app/views/admin/events/_datatable_row.haml @@ -1,4 +1,4 @@ -- cache ['admin', conference_id, program, event] do +- cache ['admin', conference_id, program, event, current_user] do %tr{ id: "event-#{event.id}" } %td = event.id