Merge pull request #1103 from Ana06/event-serializer-length

Default value for length in as_json fixed
This commit is contained in:
Stella Rouzi 2016-07-22 13:23:17 +03:00 committed by GitHub
commit 14b0669f8b
3 changed files with 3 additions and 3 deletions

View file

@ -116,7 +116,7 @@ class Event < ActiveRecord::Base
json[:room_guid] = room.try(:guid)
json[:track_color] = track.try(:color) || '#FFFFFF'
json[:length] = event_type.try(:length) || 25
json[:length] = event_type.try(:length) || EventType::LENGTH_STEP
json
end

View file

@ -36,6 +36,6 @@ class EventSerializer < ActiveModel::Serializer
# FIXME: duplicated logic from Event#as_json
def length
object.event_type.try(:length) || 25
object.event_type.try(:length) || EventType::LENGTH_STEP
end
end

View file

@ -246,7 +246,7 @@ describe Event do
expect(json_hash[:room_guid]).to be_nil
expect(json_hash[:track_color]).to eq('#FFFFFF')
expect(json_hash[:length]).to eq(25)
expect(json_hash[:length]).to eq(15)
end
end