From 0d8a77c9eff9b18736a72b14b5457e555a3b3f0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Geuken?= Date: Tue, 19 May 2015 20:02:02 +0200 Subject: [PATCH] Refactor registration_open? method The registration_period is already checked in registration_dates_given? method. No need to check it twice --- app/models/conference.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/conference.rb b/app/models/conference.rb index 13c99f8c..221af5ba 100644 --- a/app/models/conference.rb +++ b/app/models/conference.rb @@ -141,7 +141,7 @@ class Conference < ActiveRecord::Base # * +true+ -> If today is in the registration period. def registration_open? today = Date.current - if registration_period && registration_dates_given? + if registration_dates_given? (registration_period.start_date..registration_period.end_date).cover?(today) else false