Update rubocop TODO

for the new rails, capybara and performance cops.

.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-05-08 11:46:10 UTC using RuboCop version 1.50.2.
+# on 2023-05-08 11:54:05 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
@@ -14,6 +14,41 @@ Bundler/OrderedGems:
   Exclude:
     - 'Gemfile'
 
+# Offense count: 350
+# This cop supports safe autocorrection (--autocorrect).
+Capybara/CurrentPathExpectation:
+  Exclude:
+    - 'spec/features/base_controller_spec.rb'
+    - 'spec/features/cfp_ability_spec.rb'
+    - 'spec/features/conference_registration_spec.rb'
+    - 'spec/features/info_desk_ability_spec.rb'
+    - 'spec/features/organization_admin_ability_spec.rb'
+    - 'spec/features/organizer_ability_spec.rb'
+    - 'spec/features/proposals_spec.rb'
+    - 'spec/features/registration_periods_spec.rb'
+    - 'spec/features/splashpage_spec.rb'
+    - 'spec/features/ticket_purchases_spec.rb'
+    - 'spec/features/track_organizer_ability_spec.rb'
+    - 'spec/features/user_ability_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: have_no, not_to
+Capybara/NegationMatcher:
+  Exclude:
+    - 'spec/features/versions_spec.rb'
+
+# Offense count: 82
+# This cop supports safe autocorrection (--autocorrect).
+Capybara/SpecificFinders:
+  Enabled: false
+
+# Offense count: 1
+Capybara/SpecificMatcher:
+  Exclude:
+    - 'spec/features/sponsor_spec.rb'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: IndentationWidth.
@@ -467,12 +502,12 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 652
 
-# Offense count: 27
+# Offense count: 26
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 16
 
-# Offense count: 152
+# Offense count: 151
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 56
@@ -482,7 +517,7 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Max: 174
 
-# Offense count: 24
+# Offense count: 23
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 19
@@ -538,6 +573,32 @@ Naming/VariableNumber:
     - 'spec/models/payment_spec.rb'
     - 'spec/models/ticket_purchase_spec.rb'
 
+# Offense count: 1
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'app/models/conference.rb'
+
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/InefficientHashSearch:
+  Exclude:
+    - 'app/controllers/admin/versions_controller.rb'
+    - 'app/helpers/versions_helper.rb'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/MapCompact:
+  Exclude:
+    - 'app/datatables/registration_datatable.rb'
+    - 'lib/tasks/events_registrations.rake'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/StringInclude:
+  Exclude:
+    - 'app/models/commercial.rb'
+
 # Offense count: 28
 RSpec/AnyInstance:
   Exclude:
@@ -907,6 +968,343 @@ RSpec/VoidExpect:
   Exclude:
     - 'spec/models/conference_spec.rb'
 
+# Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ActiveRecordAliases:
+  Exclude:
+    - 'db/migrate/20141104131625_generate_username.rb'
+    - 'db/migrate/20141117214230_move_banner_description_to_conference.rb'
+    - 'db/migrate/20141118153918_change_venue_conference_association.rb'
+    - 'db/migrate/20141118162030_change_lodging_association_to_conference.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/ActiveRecordCallbacksOrder:
+  Exclude:
+    - 'app/models/event.rb'
+    - 'app/models/track.rb'
+    - 'app/models/venue.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ApplicationController:
+  Exclude:
+    - 'app/controllers/api/base_controller.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ApplicationMailer:
+  Exclude:
+    - 'app/mailers/mailbot.rb'
+
+# Offense count: 129
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/ApplicationRecord:
+  Enabled: false
+
+# Offense count: 10
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
+Rails/Blank:
+  Exclude:
+    - 'app/controllers/conferences_controller.rb'
+    - 'app/controllers/users/omniauth_callbacks_controller.rb'
+    - 'app/models/program.rb'
+    - 'app/models/user.rb'
+    - 'spec/factories/event_schedule.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/CompactBlank:
+  Exclude:
+    - 'app/controllers/surveys_controller.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Rails/ContentTag:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+
+# Offense count: 20
+# Configuration parameters: Include.
+# Include: db/migrate/*.rb
+Rails/CreateTableWithTimestamps:
+  Enabled: false
+
+# Offense count: 103
+# Configuration parameters: EnforcedStyle, AllowToTime.
+# SupportedStyles: strict, flexible
+Rails/Date:
+  Enabled: false
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforceForPrefixed.
+Rails/Delegate:
+  Exclude:
+    - 'app/models/event.rb'
+    - 'app/models/room.rb'
+    - 'app/models/track.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Rails/DuplicateAssociation:
+  Exclude:
+    - 'app/models/program.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Rails/DurationArithmetic:
+  Exclude:
+    - 'spec/models/program_spec.rb'
+    - 'spec/models/user_spec.rb'
+
+# Offense count: 3
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
+# Whitelist: find_by_sql
+# AllowedMethods: find_by_sql
+# AllowedReceivers: Gem::Specification
+Rails/DynamicFindBy:
+  Exclude:
+    - 'app/controllers/admin/events_controller.rb'
+    - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+Rails/EagerEvaluationLogMessage:
+  Exclude:
+    - 'app/controllers/admin/events_controller.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/controllers/proposals_controller.rb'
+    - 'app/models/event.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/EnumHash:
+  Exclude:
+    - 'app/models/conference.rb'
+    - 'app/models/survey.rb'
+    - 'app/models/survey_question.rb'
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'app/pdfs/ticket_pdf.rb'
+    - 'config/initializers/carrierwave.rb'
+    - 'lib/tasks/migrate_config.rake'
+    - 'spec/features/lodgings_spec.rb'
+    - 'spec/features/sponsor_spec.rb'
+    - 'spec/support/deprecation_shitlist.rb'
+
+# Offense count: 6
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasAndBelongsToMany:
+  Exclude:
+    - 'app/models/conference.rb'
+    - 'app/models/qanswer.rb'
+    - 'app/models/question.rb'
+    - 'app/models/registration.rb'
+    - 'app/models/vchoice.rb'
+
+# Offense count: 24
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+# Offense count: 5
+# Configuration parameters: Include.
+# Include: app/helpers/**/*.rb
+Rails/HelperInstanceVariable:
+  Exclude:
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/events_helper.rb'
+    - 'app/helpers/format_helper.rb'
+
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: numeric, symbolic
+Rails/HttpStatus:
+  Exclude:
+    - 'app/controllers/admin/commercials_controller.rb'
+    - 'app/controllers/admin/event_schedules_controller.rb'
+    - 'app/controllers/admin/programs_controller.rb'
+    - 'app/controllers/admin/tracks_controller.rb'
+    - 'app/controllers/admin/venue_commercials_controller.rb'
+    - 'app/controllers/commercials_controller.rb'
+
+# Offense count: 99
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+# Offense count: 7
+# Configuration parameters: IgnoreScopes, Include.
+# Include: app/models/**/*.rb
+Rails/InverseOf:
+  Exclude:
+    - 'app/models/booth.rb'
+    - 'app/models/conference.rb'
+    - 'app/models/event.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: app/controllers/**/*.rb, app/mailers/**/*.rb
+Rails/LexicallyScopedActionFilter:
+  Exclude:
+    - 'app/controllers/registrations_controller.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Rails/LinkToBlank:
+  Exclude:
+    - 'app/helpers/format_helper.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include.
+# Include: app/mailers/**/*.rb
+Rails/MailerName:
+  Exclude:
+    - 'app/mailers/mailbot.rb'
+
+# Offense count: 3
+Rails/OutputSafety:
+  Exclude:
+    - 'app/helpers/events_helper.rb'
+    - 'app/models/commercial.rb'
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: conservative, aggressive
+Rails/PluckInWhere:
+  Exclude:
+    - 'app/models/ability.rb'
+    - 'app/models/admin_ability.rb'
+
+# Offense count: 16
+# This cop supports safe autocorrection (--autocorrect).
+Rails/PluralizationGrammar:
+  Exclude:
+    - 'spec/models/conference_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Rails/Presence:
+  Exclude:
+    - 'app/controllers/schedules_controller.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 15
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
+Rails/Present:
+  Exclude:
+    - 'app/models/cfp.rb'
+    - 'app/models/email_settings.rb'
+    - 'app/models/event.rb'
+    - 'app/models/program.rb'
+    - 'app/models/venue.rb'
+
+# Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include.
+# Include: **/Rakefile, **/*.rake
+Rails/RakeEnvironment:
+  Exclude:
+    - 'lib/tasks/dump_db.rake'
+    - 'lib/tasks/spec.rake'
+
+# Offense count: 21
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: false
+
+# Offense count: 2
+Rails/RenderInline:
+  Exclude:
+    - 'app/controllers/conferences_controller.rb'
+    - 'app/controllers/schedules_controller.rb'
+
+# Offense count: 4
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ReversibleMigration:
+  Exclude:
+    - 'db/migrate/20170108053041_add_default_to_revision_in_conference.rb'
+    - 'db/migrate/20170715131706_make_track_state_not_null_and_add_default_value.rb'
+    - 'db/migrate/20170720134353_make_track_cfp_active_not_null.rb'
+    - 'db/migrate/20171118113113_change_visit_id_type_of_ahoy_events_to_integer.rb'
+
+# Offense count: 48
+# Configuration parameters: ForbiddenMethods, AllowedMethods.
+# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all
+Rails/SkipsModelValidations:
+  Enabled: false
+
+# Offense count: 40
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: strict, flexible
+Rails/TimeZone:
+  Exclude:
+    - 'app/models/comment.rb'
+    - 'app/models/conference.rb'
+    - 'config/environments/test.rb'
+    - 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb'
+    - 'db/migrate/20180313012253_add_timestamps_to_tickets.rb'
+    - 'lib/tasks/dump_db.rake'
+    - 'spec/controllers/admin/comments_controller_spec.rb'
+    - 'spec/factories/users.rb'
+    - 'spec/models/conference_spec.rb'
+
+# Offense count: 13
+# Configuration parameters: Include.
+# Include: app/models/**/*.rb
+Rails/UniqueValidationWithoutIndex:
+  Exclude:
+    - 'app/models/booth.rb'
+    - 'app/models/cfp.rb'
+    - 'app/models/commercial.rb'
+    - 'app/models/conference.rb'
+    - 'app/models/events_registration.rb'
+    - 'app/models/organization.rb'
+    - 'app/models/registration.rb'
+    - 'app/models/role.rb'
+    - 'app/models/subscription.rb'
+    - 'app/models/survey_reply.rb'
+    - 'app/models/survey_submission.rb'
+    - 'app/models/track.rb'
+    - 'app/models/vote.rb'
+
+# Offense count: 17
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Rails/WhereEquals:
+  Exclude:
+    - 'app/controllers/admin/registrations_controller.rb'
+    - 'app/models/admin_ability.rb'
+    - 'app/models/conference.rb'
+    - 'app/models/event_schedule.rb'
+    - 'app/models/program.rb'
+    - 'app/models/user.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Rails/WhereNot:
+  Exclude:
+    - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb'
+
 # Offense count: 3
 Security/Open:
   Exclude:
@@ -1002,15 +1400,13 @@ Style/Encoding:
     - 'app/uploaders/picture_uploader.rb'
     - 'spec/models/conference_spec.rb'
 
-# Offense count: 3
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 Style/ExpandPathArguments:
   Exclude:
-    - 'bin/bundle'
-    - 'bin/rspec'
     - 'spec/spec_helper.rb'
 
-# Offense count: 39
+# Offense count: 36
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -1068,7 +1464,7 @@ Style/HashTransformValues:
     - 'app/controllers/admin/comments_controller.rb'
     - 'app/helpers/chart_helper.rb'
 
-# Offense count: 60
+# Offense count: 58
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Enabled: false
@@ -1345,27 +1741,19 @@ Style/SoleNestedConditional:
     - 'db/migrate/20140801170430_move_event_media_to_commercial.rb'
     - 'db/migrate/20151018152439_create_programs_table.rb'
 
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: RequireEnglish.
-# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names
-Style/SpecialGlobalVars:
-  EnforcedStyle: use_perl_names
-
 # Offense count: 28
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Mode.
 Style/StringConcatenation:
   Enabled: false
 
-# Offense count: 25
+# Offense count: 17
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
     - 'Gemfile'
-    - 'bin/rspec'
     - 'config/deploy.rb'
     - 'config/environments/production.rb'
     - 'config/puma.rb'
@@ -1432,7 +1820,7 @@ Style/WordArray:
   EnforcedStyle: percent
   MinSize: 6
 
-# Offense count: 526
+# Offense count: 524
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https