From 06c60ef095f10384211083c4c60a896ab03492c1 Mon Sep 17 00:00:00 2001
From: Carlos Coelho <carlos@pencillabs.com>
Date: Fri, 4 Mar 2016 14:07:07 -0300
Subject: [PATCH] User creation if not signed in moved to helper

It makes more sense to use it as a filter, and also
makes it somewhat reusable

Signed-off-by: Carlos Coelho <carlos@pencillabs.com>
---
 app/controllers/proposal_controller.rb | 16 +---------------
 app/helpers/application_helper.rb      | 13 +++++++++++++
 2 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/app/controllers/proposal_controller.rb b/app/controllers/proposal_controller.rb
index 18e62098..bc969e2a 100644
--- a/app/controllers/proposal_controller.rb
+++ b/app/controllers/proposal_controller.rb
@@ -1,5 +1,6 @@
 class ProposalController < ApplicationController
   before_filter :authenticate_user!, except: [:show, :new, :create]
+  before_action :create_user_if_not_signed_in, only: [:create]
   load_resource :conference, find_by: :short_title
   load_resource :program, through: :conference, singleton: true
   load_and_authorize_resource :event, parent: false, through: :program
@@ -26,8 +27,6 @@ class ProposalController < ApplicationController
   def create
     @url = conference_program_proposal_index_path(@conference.short_title)
 
-    create_user_if_not_signed_in
-
     params[:event].delete :user
 
     proposal_submission
@@ -126,19 +125,6 @@ class ProposalController < ApplicationController
     params.require(:user).permit(:email, :password, :password_confirmation, :username)
   end
 
-  def create_user_if_not_signed_in
-    unless current_user
-      @user = User.new(user_params)
-      if @user.save
-        sign_in(@user)
-      else
-        flash[:error] = "Could not save user: #{@user.errors.full_messages.join(', ')}"
-        render action: 'new'
-        return
-      end
-    end
-  end
-
   def proposal_submission
     @event = Event.new(event_params)
     @event.program = @program
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 35f127b9..c1f7b671 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -296,4 +296,17 @@ module ApplicationHelper
   def unread_notifications(user)
     Comment.accessible_by(current_ability).find_since_last_login(user)
   end
+
+  def create_user_if_not_signed_in
+    unless current_user
+      @user = User.new(user_params)
+      if @user.save
+        sign_in(@user)
+      else
+        flash[:error] = "Could not save user: #{@user.errors.full_messages.join(', ')}"
+        render action: 'new'
+        return
+      end
+    end
+  end
 end