Merge pull request #3196 from openSUSE/depfu/update/rubocop-rails-2.19.1

Update rubocop-rails: 2.15.0 → 2.19.1 (minor)

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-05-08 11:54:05 UTC using RuboCop version 1.50.2.
+# on 2023-05-08 15:38:24 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -89,7 +89,7 @@ Layout/EmptyLineAfterMagicComment:
   Exclude:
     - 'spec/models/conference_spec.rb'
 
-# Offense count: 102
+# Offense count: 100
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -436,12 +436,6 @@ Lint/DuplicateHashKey:
     - 'db/migrate/20140801164901_move_conference_media_to_commercial.rb'
     - 'db/migrate/20140801170430_move_event_media_to_commercial.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowComments, AllowEmptyLambdas.
-Lint/EmptyBlock:
-  Exclude:
-    - 'spec/features/user_spec.rb'
-
 # Offense count: 4
 Lint/IneffectiveAccessModifier:
   Exclude:
@@ -627,7 +621,7 @@ RSpec/Capybara/CurrentPathExpectation:
     - 'spec/features/track_organizer_ability_spec.rb'
     - 'spec/features/user_ability_spec.rb'
 
-# Offense count: 159
+# Offense count: 161
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnabledMethods.
 RSpec/Capybara/FeatureMethods:
@@ -719,7 +713,7 @@ RSpec/EmptyLineAfterSubject:
     - 'spec/models/survey_spec.rb'
     - 'spec/models/track_spec.rb'
 
-# Offense count: 213
+# Offense count: 215
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 187
@@ -968,6 +962,14 @@ RSpec/VoidExpect:
   Exclude:
     - 'spec/models/conference_spec.rb'
 
+# Offense count: 24
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: ExpectedOrder, Include.
+# ExpectedOrder: index, show, new, edit, create, update, destroy
+# Include: app/controllers/**/*.rb
+Rails/ActionOrder:
+  Enabled: false
+
 # Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Rails/ActiveRecordAliases:
@@ -1027,11 +1029,24 @@ Rails/ContentTag:
   Exclude:
     - 'app/helpers/application_helper.rb'
 
-# Offense count: 20
+# Offense count: 13
 # Configuration parameters: Include.
 # Include: db/migrate/*.rb
 Rails/CreateTableWithTimestamps:
-  Enabled: false
+  Exclude:
+    - 'db/migrate/20121223115117_create_rooms_table.rb'
+    - 'db/migrate/20121223120413_create_event_types.rb'
+    - 'db/migrate/20130202130737_create_supporter_level_table.rb'
+    - 'db/migrate/20130202130923_create_table_supporter_registrations.rb'
+    - 'db/migrate/20130216070725_create_social_events_table.rb'
+    - 'db/migrate/20131228214532_create_vchoices.rb'
+    - 'db/migrate/20140109191145_create_qanswers.rb'
+    - 'db/migrate/20140623100942_create_visits.rb'
+    - 'db/migrate/20140623101032_create_ahoy_events.rb'
+    - 'db/migrate/20160309182642_remove_social_events_table.rb'
+    - 'db/migrate/20160628093634_create_survey_questions.rb'
+    - 'db/migrate/20170129075434_create_resources_table.rb'
+    - 'db/migrate/20170529215453_create_organizations.rb'
 
 # Offense count: 103
 # Configuration parameters: EnforcedStyle, AllowToTime.
@@ -1050,6 +1065,7 @@ Rails/Delegate:
 
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Severity.
 Rails/DuplicateAssociation:
   Exclude:
     - 'app/models/program.rb'
@@ -1065,9 +1081,9 @@ Rails/DurationArithmetic:
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers.
-# Whitelist: find_by_sql
-# AllowedMethods: find_by_sql
-# AllowedReceivers: Gem::Specification
+# Whitelist: find_by_sql, find_by_token_for
+# AllowedMethods: find_by_sql, find_by_token_for
+# AllowedReceivers: Gem::Specification, page
 Rails/DynamicFindBy:
   Exclude:
     - 'app/controllers/admin/events_controller.rb'
@@ -1143,7 +1159,7 @@ Rails/HttpStatus:
     - 'app/controllers/admin/venue_commercials_controller.rb'
     - 'app/controllers/commercials_controller.rb'
 
-# Offense count: 99
+# Offense count: 100
 Rails/I18nLocaleTexts:
   Enabled: false
 
@@ -1237,6 +1253,18 @@ Rails/RenderInline:
     - 'app/controllers/conferences_controller.rb'
     - 'app/controllers/schedules_controller.rb'
 
+# Offense count: 10
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Include.
+# Include: spec/controllers/**/*.rb, spec/requests/**/*.rb, test/controllers/**/*.rb, test/integration/**/*.rb
+Rails/ResponseParsedBody:
+  Exclude:
+    - 'spec/controllers/api/v1/conferences_controller_spec.rb'
+    - 'spec/controllers/api/v1/events_controller_spec.rb'
+    - 'spec/controllers/api/v1/rooms_controller_spec.rb'
+    - 'spec/controllers/api/v1/speakers_controller_spec.rb'
+    - 'spec/controllers/api/v1/tracks_controller_spec.rb'
+
 # Offense count: 4
 # Configuration parameters: Include.
 # Include: db/**/*.rb
@@ -1253,6 +1281,12 @@ Rails/ReversibleMigration:
 Rails/SkipsModelValidations:
   Enabled: false
 
+# Offense count: 77
+# Configuration parameters: Include.
+# Include: db/**/*.rb
+Rails/ThreeStateBooleanColumn:
+  Enabled: false
+
 # Offense count: 40
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
@@ -1269,6 +1303,13 @@ Rails/TimeZone:
     - 'spec/factories/users.rb'
     - 'spec/models/conference_spec.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Severity.
+Rails/TopLevelHashWithIndifferentAccess:
+  Exclude:
+    - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
+
 # Offense count: 13
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
@@ -1310,10 +1351,11 @@ Security/Open:
   Exclude:
     - 'app/pdfs/ticket_pdf.rb'
 
-# Offense count: 2
+# Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/ArrayIntersect:
   Exclude:
+    - 'app/helpers/application_helper.rb'
     - 'app/models/admin_ability.rb'
 
 # Offense count: 1
@@ -1780,15 +1822,14 @@ Style/StringLiteralsInInterpolation:
 Style/SymbolArray:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 10
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
-# AllowedMethods: define_method
+# AllowedMethods: define_method, mail, respond_to
 Style/SymbolProc:
   Exclude:
     - 'app/controllers/admin/comments_controller.rb'
     - 'app/controllers/admin/questions_controller.rb'
-    - 'app/controllers/admin/tracks_controller.rb'
     - 'app/models/ability.rb'
     - 'app/models/admin_ability.rb'
     - 'db/migrate/20140730104658_migrate_roles_for_cancancan.rb'

Gemfile.lock

@@ -502,17 +502,17 @@ GEM
       rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.0)
+    rubocop-ast (1.28.1)
       parser (>= 3.2.1.0)
     rubocop-capybara (2.18.0)
       rubocop (~> 1.41)
     rubocop-performance (1.17.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.15.0)
+    rubocop-rails (2.19.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 1.7.0, < 2.0)
+      rubocop (>= 1.33.0, < 2.0)
     rubocop-rspec (2.11.1)
       rubocop (~> 1.19)
     ruby-oembed (0.16.1)