gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add performance/stringreplacement rubocop cop

Browse source 
Enabled the performance/stringreplacement rubocop in the .rubocop.yml file and removed it from .rubocop_todo.yml. This cop checks for instances where gsub can be replaced with tr or delete. Supports auto correct, but there weren't any offenses.

Closes #1444
This commit is contained in:
Sunny 2017-04-07 23:58:43 -04:00
parent 46a6a59622
commit 0564d2df7a
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
.rubocop.yml
View file

@ -104,7 +104,7 @@ Style/TrailingBlankLines:
Style/TrailingWhitespace: Style/TrailingWhitespace:
Enabled: true Enabled: true
#This cop checks for numeric comparisons that can be replaced by a predicate method. # This cop checks for numeric comparisons that can be replaced by a predicate method.
Style/ZeroLengthPredicate: Style/ZeroLengthPredicate:
Enabled: true Enabled: true
@ -183,3 +183,9 @@ Rails:
# Avoid use of old-style attribute validation # Avoid use of old-style attribute validation
Rails/Validation: Rails/Validation:
Enabled: true Enabled: true
#################### Performance ###############################
# Identifies places where gsub can be replaced by tr or delete.
Performance/StringReplacement:
Enabled: true

6
.rubocop_todo.yml
View file

@ -48,12 +48,6 @@ Metrics/ModuleLength:
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Max: 15 Max: 15
# Offense count: 1
# Cop supports --auto-correct.
Performance/StringReplacement:
Exclude:
- 'spec/support/save_feature_failures.rb'
# Offense count: 13 # Offense count: 13
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, Include. # Configuration parameters: EnforcedStyle, SupportedStyles, Include.