gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add user to cache dependencies of event proposal tab

Browse source 
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find visible css ".rating.bright" … 0 times, found 3 matches
    expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:57

i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.

resolves #2767
This commit is contained in:
Andrew Kvalheim 2023-03-01 11:52:16 -08:00
parent 1563881153
commit 04f6a73d73
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/views/admin/events/_proposal.html.haml
View file

@ -1,4 +1,4 @@
- cache ['admin/event', @conference, @program, @event] do
- cache ['admin/event', @conference, @program, @event, current_user] do
.row
.col-md-12
%h3