From 0104671e012b40aa5eb1a9a552bf2a4345bb35d5 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Wed, 18 Aug 2021 13:14:44 +0200 Subject: [PATCH] Stop validating factories in specs We do validate all of them in a before(:suite) already. --- spec/controllers/admin/users_controller_spec.rb | 9 --------- spec/models/booth_spec.rb | 4 ---- spec/models/conference_spec.rb | 4 ---- spec/models/email_settings_spec.rb | 4 ---- spec/models/event_schedule_spec.rb | 4 ---- spec/models/event_spec.rb | 4 ---- spec/models/event_type_spec.rb | 4 ---- spec/models/payment_spec.rb | 6 ------ spec/models/physical_ticket_spec.rb | 16 ---------------- spec/models/program_spec.rb | 8 -------- spec/models/registration_period_spec.rb | 4 ---- spec/models/registration_spec.rb | 4 ---- spec/models/resource_spec.rb | 4 ---- spec/models/sponsor_spec.rb | 4 ---- spec/models/sponsorship_level_spec.rb | 4 ---- spec/models/ticket_purchase_spec.rb | 4 ---- spec/models/ticket_spec.rb | 5 ----- spec/models/track_spec.rb | 4 ---- spec/models/user_spec.rb | 4 ---- spec/models/vote_spec.rb | 4 ---- 20 files changed, 104 deletions(-) delete mode 100644 spec/models/physical_ticket_spec.rb diff --git a/spec/controllers/admin/users_controller_spec.rb b/spec/controllers/admin/users_controller_spec.rb index 51dfb04c..bf5d125e 100644 --- a/spec/controllers/admin/users_controller_spec.rb +++ b/spec/controllers/admin/users_controller_spec.rb @@ -38,15 +38,6 @@ describe Admin::UsersController do before :each do patch :update, params: { id: user.id, user: { name: 'new name', email: 'new_email@osem.io' } } end - - it 'locates requested @user' do - expect(build(:user, id: user.id)).to eq(user) - end - it 'changes @users attributes' do - expect(build( - :user, email: 'email_new@osem.io', id: user.id).email) - .to eq('email_new@osem.io') - end it 'redirects to the updated user' do expect(response).to redirect_to admin_users_path end diff --git a/spec/models/booth_spec.rb b/spec/models/booth_spec.rb index cec4d4ac..8a501767 100644 --- a/spec/models/booth_spec.rb +++ b/spec/models/booth_spec.rb @@ -7,10 +7,6 @@ describe Booth do let!(:conference) { create(:conference) } describe 'validation' do - it 'has a valid factory' do - expect(build(:booth)).to be_valid - end - it { is_expected.to validate_presence_of(:reasoning) } it { is_expected.to validate_presence_of(:description) } it { is_expected.to validate_presence_of(:responsibles) } diff --git a/spec/models/conference_spec.rb b/spec/models/conference_spec.rb index 1c3ecb3b..fc593a14 100755 --- a/spec/models/conference_spec.rb +++ b/spec/models/conference_spec.rb @@ -1484,10 +1484,6 @@ describe Conference do describe 'validations' do - it 'has a valid factory' do - expect(build(:conference)).to be_valid - end - it 'is not valid without a title' do should validate_presence_of(:title) end diff --git a/spec/models/email_settings_spec.rb b/spec/models/email_settings_spec.rb index 875dba6d..f79857f7 100644 --- a/spec/models/email_settings_spec.rb +++ b/spec/models/email_settings_spec.rb @@ -23,10 +23,6 @@ describe EmailSettings do } end - it 'has a valid factory' do - expect(build(:email_settings)).to be_valid - end - describe '#get_values' do context 'user has name' do it 'returns correct key-value pairs' do diff --git a/spec/models/event_schedule_spec.rb b/spec/models/event_schedule_spec.rb index 56cedcd4..f111e896 100644 --- a/spec/models/event_schedule_spec.rb +++ b/spec/models/event_schedule_spec.rb @@ -12,10 +12,6 @@ describe EventSchedule do end describe 'validation' do - it 'has a valid factory' do - expect(build(:event_schedule)).to be_valid - end - it { is_expected.to validate_presence_of(:schedule) } it { is_expected.to validate_presence_of(:event) } it { is_expected.to validate_presence_of(:room) } diff --git a/spec/models/event_spec.rb b/spec/models/event_spec.rb index 92768222..d299bedf 100644 --- a/spec/models/event_spec.rb +++ b/spec/models/event_spec.rb @@ -18,10 +18,6 @@ describe Event do end describe 'validation' do - it 'has a valid factory' do - expect(build(:event)).to be_valid - end - it { is_expected.to validate_presence_of(:title) } it { is_expected.to validate_presence_of(:abstract) } it { is_expected.to validate_presence_of(:program) } diff --git a/spec/models/event_type_spec.rb b/spec/models/event_type_spec.rb index 9fb65950..2b696ead 100644 --- a/spec/models/event_type_spec.rb +++ b/spec/models/event_type_spec.rb @@ -12,10 +12,6 @@ describe EventType do end describe 'validation' do - it 'has a valid factory' do - expect(build(:event_type)).to be_valid - end - it { is_expected.to validate_presence_of(:title) } it { is_expected.to validate_presence_of(:minimum_abstract_length) } it { is_expected.to validate_presence_of(:maximum_abstract_length) } diff --git a/spec/models/payment_spec.rb b/spec/models/payment_spec.rb index f011a749..702ad725 100644 --- a/spec/models/payment_spec.rb +++ b/spec/models/payment_spec.rb @@ -13,14 +13,8 @@ describe Payment do end describe 'validations' do - it 'has a valid factory' do - expect(build(:payment)).to be_valid - end - it { is_expected.to validate_presence_of(:status) } - it { is_expected.to validate_presence_of(:user_id) } - it { is_expected.to validate_presence_of(:conference_id) } end diff --git a/spec/models/physical_ticket_spec.rb b/spec/models/physical_ticket_spec.rb deleted file mode 100644 index 31afd621..00000000 --- a/spec/models/physical_ticket_spec.rb +++ /dev/null @@ -1,16 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -describe PhysicalTicket do - - describe 'association' do - it { is_expected.to belong_to :ticket_purchase } - end - - describe 'validations' do - it 'has a valid factory' do - expect(build(:physical_ticket)).to be_valid - end - end -end diff --git a/spec/models/program_spec.rb b/spec/models/program_spec.rb index e8db5880..1aa7eb29 100644 --- a/spec/models/program_spec.rb +++ b/spec/models/program_spec.rb @@ -25,14 +25,6 @@ describe Program do end describe 'validation' do - it 'has a valid factory' do - expect(build(:program)).to be_valid - end - - it 'is valid for rating of 5' do - expect(build(:program, rating: 5)).to be_valid - end - it { is_expected.to validate_numericality_of(:rating).is_greater_than_or_equal_to(0).is_less_than_or_equal_to(10).only_integer } it { is_expected.to validate_numericality_of(:schedule_interval).is_greater_than_or_equal_to(5).is_less_than_or_equal_to(60) } diff --git a/spec/models/registration_period_spec.rb b/spec/models/registration_period_spec.rb index 10da0684..ae33e51d 100644 --- a/spec/models/registration_period_spec.rb +++ b/spec/models/registration_period_spec.rb @@ -8,10 +8,6 @@ describe RegistrationPeriod do let!(:registration_period) { create(:registration_period, start_date: Date.today - 2, end_date: Date.today - 1, conference: conference) } describe 'validations' do - it 'has a valid factory' do - expect(build(:registration_period)).to be_valid - end - it 'is not valid without a start_date' do should validate_presence_of(:start_date) end diff --git a/spec/models/registration_spec.rb b/spec/models/registration_spec.rb index d6c86838..940a6044 100644 --- a/spec/models/registration_spec.rb +++ b/spec/models/registration_spec.rb @@ -9,10 +9,6 @@ describe Registration do let!(:registration) { create(:registration, conference: conference, user: user) } describe 'validation' do - it 'has a valid factory' do - expect(build(:registration)).to be_valid - end - it { is_expected.to validate_presence_of(:user) } it 'validates uniqueness of user in scope of conference' do diff --git a/spec/models/resource_spec.rb b/spec/models/resource_spec.rb index d70e3144..9ef5a71a 100644 --- a/spec/models/resource_spec.rb +++ b/spec/models/resource_spec.rb @@ -24,10 +24,6 @@ describe Resource do it { is_expected.to allow_value(0).for(:quantity) } - it 'has a valid factory' do - expect(build(:resource)).to be_valid - end - it 'is not valid with used greater than quantity' do resource.used = resource.quantity + 1 expect(resource.valid?).to eq false diff --git a/spec/models/sponsor_spec.rb b/spec/models/sponsor_spec.rb index 7f6e3e50..fcab9330 100644 --- a/spec/models/sponsor_spec.rb +++ b/spec/models/sponsor_spec.rb @@ -4,10 +4,6 @@ require 'spec_helper' describe Sponsor do describe 'validations' do - it 'has a valid factory' do - expect(build(:sponsor)).to be_valid - end - it 'is not valid without a name' do should validate_presence_of(:name) end diff --git a/spec/models/sponsorship_level_spec.rb b/spec/models/sponsorship_level_spec.rb index c6b71a88..5636c730 100644 --- a/spec/models/sponsorship_level_spec.rb +++ b/spec/models/sponsorship_level_spec.rb @@ -5,10 +5,6 @@ require 'spec_helper' describe SponsorshipLevel do describe 'validation' do - it 'has a valid factory' do - expect(build(:sponsorship_level)).to be_valid - end - it 'is not valid without a title' do should validate_presence_of(:title) end diff --git a/spec/models/ticket_purchase_spec.rb b/spec/models/ticket_purchase_spec.rb index 688864c6..6c28681b 100644 --- a/spec/models/ticket_purchase_spec.rb +++ b/spec/models/ticket_purchase_spec.rb @@ -5,10 +5,6 @@ require 'spec_helper' describe TicketPurchase do describe 'validations' do - it 'has a valid factory' do - expect(build(:ticket_purchase)).to be_valid - end - it 'is not valid without a conference_id' do should validate_presence_of(:conference_id) end diff --git a/spec/models/ticket_spec.rb b/spec/models/ticket_spec.rb index 0dcb5cad..858e4d37 100644 --- a/spec/models/ticket_spec.rb +++ b/spec/models/ticket_spec.rb @@ -8,11 +8,6 @@ describe Ticket do let(:user) { create(:user) } describe 'validation' do - - it 'has a valid factory' do - expect(build(:ticket)).to be_valid - end - it 'is not valid without a title' do should validate_presence_of(:title) end diff --git a/spec/models/track_spec.rb b/spec/models/track_spec.rb index b58fc622..27066442 100644 --- a/spec/models/track_spec.rb +++ b/spec/models/track_spec.rb @@ -17,10 +17,6 @@ describe Track do end describe 'validation' do - it 'has a valid factory' do - expect(build(:track)).to be_valid - end - it { is_expected.to validate_presence_of(:name) } it { is_expected.to allow_value('#ABCDEF').for(:color) } it { is_expected.to allow_value('#124689').for(:color) } diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb index 4c20b752..eda4d725 100644 --- a/spec/models/user_spec.rb +++ b/spec/models/user_spec.rb @@ -21,10 +21,6 @@ describe User do let(:events_registration) { create(:events_registration, event: event1, registration: registration) } describe 'validation' do - it 'has a valid factory' do - expect(build(:user)).to be_valid - end - it { is_expected.to validate_presence_of(:email) } it { is_expected.to validate_presence_of(:username) } it { is_expected.to validate_uniqueness_of(:username).ignoring_case_sensitivity } diff --git a/spec/models/vote_spec.rb b/spec/models/vote_spec.rb index 39afb352..7ed45a36 100644 --- a/spec/models/vote_spec.rb +++ b/spec/models/vote_spec.rb @@ -6,10 +6,6 @@ describe Vote do let!(:vote) { create(:vote) } describe 'validation' do - it 'has a valid factory' do - expect(build(:vote)).to be_valid - end - it { is_expected.to validate_uniqueness_of(:user_id).scoped_to(:event_id) } # This is testing the relationship instead of using the shoulda-matchers